wip

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

Author: tobiasKaminsky

app/src/androidTest/java/com/nextcloud/test/GrantStoragePermissionRule.kt

@@ -27,6 +27,7 @@ class GrantStoragePermissionRule private constructor() {
             Build.VERSION.SDK_INT < Build.VERSION_CODES.R -> GrantPermissionRule.grant(
                 Manifest.permission.WRITE_EXTERNAL_STORAGE
             )
+
             else -> GrantManageExternalStoragePermissionRule()
         }
     }

app/src/androidTest/java/com/owncloud/android/files/services/FileUploaderIT.kt

@@ -57,9 +57,9 @@ abstract class FileUploaderIT : AbstractOnServerIT() {
         uploadsStorageManager = UploadsStorageManager(accountManager, contentResolver)
     }
 
-    /**
-     * uploads a file, overwrites it with an empty one, check if overwritten
-     */
+    // /**
+    // * uploads a file, overwrites it with an empty one, check if overwritten
+    // */
     // disabled, flaky test
     // @Test
     // fun testKeepLocalAndOverwriteRemote() {

app/src/androidTest/java/com/owncloud/android/ui/trashbin/TrashbinLocalRepository.kt

@@ -28,6 +28,7 @@ class TrashbinLocalRepository(private val testCase: TrashbinActivityIT.TestCase)
     override fun getFolder(remotePath: String?, callback: LoadFolderCallback?) {
         when (testCase) {
             TrashbinActivityIT.TestCase.ERROR -> callback?.onError(R.string.trashbin_loading_failed)
+
             TrashbinActivityIT.TestCase.FILES -> {
                 val files = ArrayList<TrashbinFile>()
                 files.add(
@@ -69,6 +70,7 @@ class TrashbinLocalRepository(private val testCase: TrashbinActivityIT.TestCase)
 
                 callback?.onSuccess(files)
             }
+
             TrashbinActivityIT.TestCase.EMPTY -> callback?.onSuccess(ArrayList<TrashbinFile>())
         }
     }

app/src/main/java/com/nextcloud/client/assistant/extensions/TaskExtensions.kt

@@ -10,7 +10,6 @@
 package com.nextcloud.client.assistant.extensions
 
 import android.content.Context
-import androidx.compose.ui.res.stringResource
 import com.nextcloud.utils.date.DateFormatPattern
 import com.nextcloud.utils.date.DateFormatter
 import com.owncloud.android.R
@@ -58,18 +57,23 @@ private fun Task.getStatusIconV1(): Int = when (status) {
     "0" -> {
         R.drawable.ic_unknown
     }
+
     "1" -> {
         R.drawable.ic_clock
     }
+
     "2" -> {
         R.drawable.ic_modification_desc
     }
+
     "3" -> {
         R.drawable.ic_check_circle_outline
     }
+
     "4" -> {
         R.drawable.image_fail
     }
+
     else -> {
         R.drawable.ic_unknown
     }
@@ -79,18 +83,23 @@ private fun Task.getStatusIconDescriptionV1(): Int = when (status) {
     "0" -> {
         R.string.assistant_task_status_unknown
     }
+
     "1" -> {
         R.string.assistant_task_status_scheduled
     }
+
     "2" -> {
         R.string.assistant_task_status_running
     }
+
     "3" -> {
         R.string.assistant_task_status_successful
     }
+
     "4" -> {
         R.string.assistant_task_status_failed
     }
+
     else -> {
         R.string.assistant_task_status_unknown
     }
@@ -100,18 +109,23 @@ private fun Task.getStatusIconV2(): Int = when (status) {
     "STATUS_UNKNOWN" -> {
         R.drawable.ic_unknown
     }
+
     "STATUS_SCHEDULED" -> {
         R.drawable.ic_clock
     }
+
     "STATUS_RUNNING" -> {
         R.drawable.ic_modification_desc
     }
+
     "STATUS_SUCCESSFUL" -> {
         R.drawable.ic_check_circle_outline
     }
+
     "STATUS_FAILED" -> {
         R.drawable.image_fail
     }
+
     else -> {
         R.drawable.ic_unknown
     }
@@ -121,18 +135,23 @@ private fun Task.getStatusIconDescriptionV2(): Int = when (status) {
     "STATUS_UNKNOWN" -> {
         R.string.assistant_task_status_unknown
     }
+
     "STATUS_SCHEDULED" -> {
         R.string.assistant_task_status_scheduled
     }
+
     "STATUS_RUNNING" -> {
         R.string.assistant_task_status_running
     }
+
     "STATUS_SUCCESSFUL" -> {
         R.string.assistant_task_status_successful
     }
+
     "STATUS_FAILED" -> {
         R.string.assistant_task_status_failed
     }
+
     else -> {
         R.string.assistant_task_status_unknown
     }

app/src/main/java/com/nextcloud/client/documentscan/DocumentScanActivity.kt

@@ -103,10 +103,12 @@ class DocumentScanActivity :
                         viewModel.onClickDone()
                         true
                     }
+
                     android.R.id.home -> {
                         onBackPressedDispatcher.onBackPressed()
                         true
                     }
+
                     else -> false
                 }
             }
@@ -129,6 +131,7 @@ class DocumentScanActivity :
                         startPageScan()
                     }
                 }
+
                 is DocumentScanViewModel.UIState.RequestExportState -> {
                     updateButtonsEnabled(false)
                     if (state.shouldRequestExportType) {
@@ -137,6 +140,7 @@ class DocumentScanActivity :
                     }
                 }
             }
+
             DocumentScanViewModel.UIState.DoneState, DocumentScanViewModel.UIState.CanceledState -> {
                 finish()
             }

app/src/main/java/com/nextcloud/client/documentscan/DocumentScanViewModel.kt

@@ -138,6 +138,7 @@ class DocumentScanViewModel @Inject constructor(
             ExportType.PDF -> {
                 exportToPdf(state.pageList)
             }
+
             ExportType.IMAGES -> {
                 exportToImages(state.pageList)
             }

app/src/main/java/com/nextcloud/client/editimage/EditImageActivity.kt

@@ -174,6 +174,7 @@ class EditImageActivity :
         // determine output file format
         format = when (file.mimeType) {
             MimeType.PNG -> Bitmap.CompressFormat.PNG
+
             MimeType.WEBP -> {
                 if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.R) {
                     Bitmap.CompressFormat.WEBP_LOSSY

app/src/main/java/com/nextcloud/client/errorhandling/ShowErrorActivity.kt

@@ -63,6 +63,7 @@ class ShowErrorActivity : AppCompatActivity() {
             onClickedShare()
             true
         }
+
         else -> super.onOptionsItemSelected(item)
     }
 

app/src/main/java/com/nextcloud/client/etm/EtmActivity.kt

@@ -57,6 +57,7 @@ class EtmActivity :
             }
             true
         }
+
         else -> super.onOptionsItemSelected(item)
     }
 

app/src/main/java/com/nextcloud/client/etm/pages/EtmAccountsFragment.kt

@@ -55,6 +55,7 @@ class EtmAccountsFragment : EtmBaseFragment() {
             onClickedShare()
             true
         }
+
         else -> super.onOptionsItemSelected(item)
     }