Skip to content

Commit d11a43d

Browse files
committed
add custom permission radio button
Signed-off-by: alperozturk <alper_ozturk@proton.me>
1 parent 5da26e4 commit d11a43d

3 files changed

Lines changed: 153 additions & 142 deletions

File tree

app/src/androidTest/java/com/owncloud/android/ui/fragment/FileDetailSharingFragmentIT.kt

Lines changed: 38 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -293,34 +293,34 @@ class FileDetailSharingFragmentIT : AbstractIT() {
293293
onView(ViewMatchers.withId(R.id.menu_share_advanced_permissions)).perform(ViewActions.click())
294294

295295
// validate view shown on screen
296-
onView(ViewMatchers.withId(R.id.share_process_permission_read_only)).check(matches(isDisplayed()))
297-
onView(ViewMatchers.withId(R.id.share_process_permission_upload_editing)).check(matches(isDisplayed()))
298-
onView(ViewMatchers.withId(R.id.share_process_permission_file_drop)).check(matches(isDisplayed()))
296+
onView(ViewMatchers.withId(R.id.view_only_radio_button)).check(matches(isDisplayed()))
297+
onView(ViewMatchers.withId(R.id.editing_radio_button)).check(matches(isDisplayed()))
298+
onView(ViewMatchers.withId(R.id.file_drop_radio_button)).check(matches(isDisplayed()))
299299
onView(ViewMatchers.withId(R.id.share_process_hide_download_checkbox)).check(matches(isDisplayed()))
300300
onView(ViewMatchers.withId(R.id.share_process_set_password_switch)).check(matches(isDisplayed()))
301301
onView(ViewMatchers.withId(R.id.share_process_change_name_switch)).check(matches(isDisplayed()))
302302
onView(ViewMatchers.withId(R.id.share_process_allow_resharing_checkbox)).check(matches(not(isDisplayed())))
303303

304304
// read-only
305-
onView(ViewMatchers.withId(R.id.share_process_permission_read_only)).check(matches(isChecked()))
306-
onView(ViewMatchers.withId(R.id.share_process_permission_upload_editing)).check(matches(isNotChecked()))
307-
onView(ViewMatchers.withId(R.id.share_process_permission_file_drop)).check(matches(isNotChecked()))
305+
onView(ViewMatchers.withId(R.id.view_only_radio_button)).check(matches(isChecked()))
306+
onView(ViewMatchers.withId(R.id.editing_radio_button)).check(matches(isNotChecked()))
307+
onView(ViewMatchers.withId(R.id.file_drop_radio_button)).check(matches(isNotChecked()))
308308
goBack()
309309

310310
// upload and editing
311311
publicShare.permissions = MAXIMUM_PERMISSIONS_FOR_FOLDER
312312
openAdvancedPermissions(sut, publicShare)
313-
onView(ViewMatchers.withId(R.id.share_process_permission_read_only)).check(matches(isNotChecked()))
314-
onView(ViewMatchers.withId(R.id.share_process_permission_upload_editing)).check(matches(isChecked()))
315-
onView(ViewMatchers.withId(R.id.share_process_permission_file_drop)).check(matches(isNotChecked()))
313+
onView(ViewMatchers.withId(R.id.view_only_radio_button)).check(matches(isNotChecked()))
314+
onView(ViewMatchers.withId(R.id.editing_radio_button)).check(matches(isChecked()))
315+
onView(ViewMatchers.withId(R.id.file_drop_radio_button)).check(matches(isNotChecked()))
316316
goBack()
317317

318318
// file drop
319319
publicShare.permissions = 4
320320
openAdvancedPermissions(sut, publicShare)
321-
onView(ViewMatchers.withId(R.id.share_process_permission_read_only)).check(matches(isNotChecked()))
322-
onView(ViewMatchers.withId(R.id.share_process_permission_upload_editing)).check(matches(isNotChecked()))
323-
onView(ViewMatchers.withId(R.id.share_process_permission_file_drop)).check(matches(isChecked()))
321+
onView(ViewMatchers.withId(R.id.view_only_radio_button)).check(matches(isNotChecked()))
322+
onView(ViewMatchers.withId(R.id.editing_radio_button)).check(matches(isNotChecked()))
323+
onView(ViewMatchers.withId(R.id.file_drop_radio_button)).check(matches(isChecked()))
324324
goBack()
325325

326326
// password protection
@@ -420,25 +420,25 @@ class FileDetailSharingFragmentIT : AbstractIT() {
420420
onView(ViewMatchers.withId(R.id.menu_share_advanced_permissions)).perform(ViewActions.click())
421421

422422
// validate view shown on screen
423-
onView(ViewMatchers.withId(R.id.share_process_permission_read_only)).check(matches(isDisplayed()))
424-
onView(ViewMatchers.withId(R.id.share_process_permission_upload_editing)).check(matches(isDisplayed()))
425-
onView(ViewMatchers.withId(R.id.share_process_permission_file_drop)).check(matches(not(isDisplayed())))
423+
onView(ViewMatchers.withId(R.id.view_only_radio_button)).check(matches(isDisplayed()))
424+
onView(ViewMatchers.withId(R.id.editing_radio_button)).check(matches(isDisplayed()))
425+
onView(ViewMatchers.withId(R.id.file_drop_radio_button)).check(matches(not(isDisplayed())))
426426
onView(ViewMatchers.withId(R.id.share_process_hide_download_checkbox)).check(matches(isDisplayed()))
427427
onView(ViewMatchers.withId(R.id.share_process_set_password_switch)).check(matches(isDisplayed()))
428428
onView(ViewMatchers.withId(R.id.share_process_change_name_switch)).check(matches(isDisplayed()))
429429
onView(ViewMatchers.withId(R.id.share_process_allow_resharing_checkbox)).check(matches(not(isDisplayed())))
430430

431431
// read-only
432432
publicShare.permissions = 17 // from server
433-
onView(ViewMatchers.withId(R.id.share_process_permission_read_only)).check(matches(isChecked()))
434-
onView(ViewMatchers.withId(R.id.share_process_permission_upload_editing)).check(matches(isNotChecked()))
433+
onView(ViewMatchers.withId(R.id.view_only_radio_button)).check(matches(isChecked()))
434+
onView(ViewMatchers.withId(R.id.editing_radio_button)).check(matches(isNotChecked()))
435435
goBack()
436436

437437
// editing
438438
publicShare.permissions = MAXIMUM_PERMISSIONS_FOR_FILE // from server
439439
openAdvancedPermissions(sut, publicShare)
440-
onView(ViewMatchers.withId(R.id.share_process_permission_read_only)).check(matches(isNotChecked()))
441-
onView(ViewMatchers.withId(R.id.share_process_permission_upload_editing)).check(matches(isChecked()))
440+
onView(ViewMatchers.withId(R.id.view_only_radio_button)).check(matches(isNotChecked()))
441+
onView(ViewMatchers.withId(R.id.editing_radio_button)).check(matches(isChecked()))
442442
goBack()
443443

444444
// hide download
@@ -536,25 +536,25 @@ class FileDetailSharingFragmentIT : AbstractIT() {
536536
waitForIdleSync()
537537

538538
// validate view shown on screen
539-
onView(ViewMatchers.withId(R.id.share_process_permission_read_only)).check(matches(isDisplayed()))
540-
onView(ViewMatchers.withId(R.id.share_process_permission_upload_editing)).check(matches(isDisplayed()))
541-
onView(ViewMatchers.withId(R.id.share_process_permission_file_drop)).check(matches(not(isDisplayed())))
539+
onView(ViewMatchers.withId(R.id.view_only_radio_button)).check(matches(isDisplayed()))
540+
onView(ViewMatchers.withId(R.id.editing_radio_button)).check(matches(isDisplayed()))
541+
onView(ViewMatchers.withId(R.id.file_drop_radio_button)).check(matches(not(isDisplayed())))
542542
onView(ViewMatchers.withId(R.id.share_process_hide_download_checkbox)).check(matches(not(isDisplayed())))
543543
onView(ViewMatchers.withId(R.id.share_process_set_password_switch)).check(matches(not(isDisplayed())))
544544
onView(ViewMatchers.withId(R.id.share_process_change_name_switch)).check(matches(not(isDisplayed())))
545545
onView(ViewMatchers.withId(R.id.share_process_allow_resharing_checkbox)).check(matches(isDisplayed()))
546546

547547
// read-only
548548
userShare.permissions = 17 // from server
549-
onView(ViewMatchers.withId(R.id.share_process_permission_read_only)).check(matches(isChecked()))
550-
onView(ViewMatchers.withId(R.id.share_process_permission_upload_editing)).check(matches(isNotChecked()))
549+
onView(ViewMatchers.withId(R.id.view_only_radio_button)).check(matches(isChecked()))
550+
onView(ViewMatchers.withId(R.id.editing_radio_button)).check(matches(isNotChecked()))
551551
goBack()
552552

553553
// editing
554554
userShare.permissions = MAXIMUM_PERMISSIONS_FOR_FILE // from server
555555
openAdvancedPermissions(sut, userShare)
556-
onView(ViewMatchers.withId(R.id.share_process_permission_read_only)).check(matches(isNotChecked()))
557-
onView(ViewMatchers.withId(R.id.share_process_permission_upload_editing)).check(matches(isChecked()))
556+
onView(ViewMatchers.withId(R.id.view_only_radio_button)).check(matches(isNotChecked()))
557+
onView(ViewMatchers.withId(R.id.editing_radio_button)).check(matches(isChecked()))
558558
goBack()
559559

560560
// allow reshare
@@ -659,35 +659,35 @@ class FileDetailSharingFragmentIT : AbstractIT() {
659659
onView(ViewMatchers.withId(R.id.menu_share_advanced_permissions)).perform(ViewActions.click())
660660

661661
// validate view shown on screen
662-
onView(ViewMatchers.withId(R.id.share_process_permission_read_only)).check(matches(isDisplayed()))
663-
onView(ViewMatchers.withId(R.id.share_process_permission_upload_editing)).check(matches(isDisplayed()))
664-
onView(ViewMatchers.withId(R.id.share_process_permission_file_drop)).check(matches(isDisplayed()))
662+
onView(ViewMatchers.withId(R.id.view_only_radio_button)).check(matches(isDisplayed()))
663+
onView(ViewMatchers.withId(R.id.editing_radio_button)).check(matches(isDisplayed()))
664+
onView(ViewMatchers.withId(R.id.file_drop_radio_button)).check(matches(isDisplayed()))
665665
onView(ViewMatchers.withId(R.id.share_process_hide_download_checkbox)).check(matches(not(isDisplayed())))
666666
onView(ViewMatchers.withId(R.id.share_process_set_password_switch)).check(matches(not(isDisplayed())))
667667
onView(ViewMatchers.withId(R.id.share_process_change_name_switch)).check(matches(not(isDisplayed())))
668668
onView(ViewMatchers.withId(R.id.share_process_allow_resharing_checkbox)).check(matches(isDisplayed()))
669669

670670
// read-only
671671
userShare.permissions = 17 // from server
672-
onView(ViewMatchers.withId(R.id.share_process_permission_read_only)).check(matches(isChecked()))
673-
onView(ViewMatchers.withId(R.id.share_process_permission_upload_editing)).check(matches(isNotChecked()))
674-
onView(ViewMatchers.withId(R.id.share_process_permission_file_drop)).check(matches(isNotChecked()))
672+
onView(ViewMatchers.withId(R.id.view_only_radio_button)).check(matches(isChecked()))
673+
onView(ViewMatchers.withId(R.id.editing_radio_button)).check(matches(isNotChecked()))
674+
onView(ViewMatchers.withId(R.id.file_drop_radio_button)).check(matches(isNotChecked()))
675675
goBack()
676676

677677
// allow upload & editing
678678
userShare.permissions = MAXIMUM_PERMISSIONS_FOR_FOLDER // from server
679679
openAdvancedPermissions(sut, userShare)
680-
onView(ViewMatchers.withId(R.id.share_process_permission_read_only)).check(matches(isNotChecked()))
681-
onView(ViewMatchers.withId(R.id.share_process_permission_upload_editing)).check(matches(isChecked()))
682-
onView(ViewMatchers.withId(R.id.share_process_permission_file_drop)).check(matches(isNotChecked()))
680+
onView(ViewMatchers.withId(R.id.view_only_radio_button)).check(matches(isNotChecked()))
681+
onView(ViewMatchers.withId(R.id.editing_radio_button)).check(matches(isChecked()))
682+
onView(ViewMatchers.withId(R.id.file_drop_radio_button)).check(matches(isNotChecked()))
683683
goBack()
684684

685685
// file drop
686686
userShare.permissions = 4
687687
openAdvancedPermissions(sut, userShare)
688-
onView(ViewMatchers.withId(R.id.share_process_permission_read_only)).check(matches(isNotChecked()))
689-
onView(ViewMatchers.withId(R.id.share_process_permission_upload_editing)).check(matches(isNotChecked()))
690-
onView(ViewMatchers.withId(R.id.share_process_permission_file_drop)).check(matches(isChecked()))
688+
onView(ViewMatchers.withId(R.id.view_only_radio_button)).check(matches(isNotChecked()))
689+
onView(ViewMatchers.withId(R.id.editing_radio_button)).check(matches(isNotChecked()))
690+
onView(ViewMatchers.withId(R.id.file_drop_radio_button)).check(matches(isChecked()))
691691
goBack()
692692

693693
// allow reshare

0 commit comments

Comments
 (0)