Skip to content

Commit d29b199

Browse files
style: Style the bottom sheet buttons and dividers like bottom sheet menus
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
1 parent 4d03998 commit d29b199

4 files changed

Lines changed: 25 additions & 17 deletions

File tree

app/src/main/java/com/owncloud/android/ui/fragment/OCFileListBottomSheetDialog.kt

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -148,13 +148,12 @@ class OCFileListBottomSheetDialog(
148148
val itemHeight = context.resources.getDimensionPixelSize(R.dimen.bottom_sheet_item_height)
149149
val standardPadding = context.resources.getDimensionPixelSize(R.dimen.standard_padding)
150150
val iconSize = context.resources.getDimensionPixelSize(R.dimen.iconized_single_line_item_icon_size)
151-
val startPadding = context.resources.getDimensionPixelSize(R.dimen.creator_container_start_padding)
152151

153152
for (creator in directEditing.creators.values) {
154153
val creatorButton = MaterialButton(
155154
ContextThemeWrapper(
156155
context,
157-
com.google.android.material.R.style.Widget_Material3_Button_IconButton
156+
R.style.ThemeOverlay_App_Button_BottomSheetItem
158157
),
159158
null,
160159
com.google.android.material.R.attr.materialButtonStyle
@@ -166,9 +165,7 @@ class OCFileListBottomSheetDialog(
166165
)
167166

168167
gravity = Gravity.START or Gravity.CENTER_VERTICAL
169-
setPaddingRelative(startPadding, 0, standardPadding, 0)
170-
insetTop = 0
171-
insetBottom = 0
168+
setPaddingRelative(standardPadding, 0, standardPadding, 0)
172169

173170
val buttonText = String.format(
174171
fileActivity.getString(R.string.editor_placeholder),

app/src/main/res/layout/file_list_actions_bottom_sheet_fragment.xml

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@
4343

4444
<com.google.android.material.button.MaterialButton
4545
android:id="@+id/menu_upload_files"
46-
style="@style/Widget.Material3.Button.IconButton"
46+
style="@style/Widget.App.Button.BottomSheetItem"
4747
android:layout_width="match_parent"
4848
android:layout_height="@dimen/bottom_sheet_item_height"
4949
android:contentDescription="@string/upload_files"
@@ -61,7 +61,7 @@
6161

6262
<com.google.android.material.button.MaterialButton
6363
android:id="@+id/menu_upload_from_app"
64-
style="@style/Widget.Material3.Button.IconButton"
64+
style="@style/Widget.App.Button.BottomSheetItem"
6565
android:layout_width="match_parent"
6666
android:layout_height="@dimen/bottom_sheet_item_height"
6767
android:contentDescription="@string/upload_content_from_other_apps"
@@ -79,7 +79,7 @@
7979

8080
<com.google.android.material.button.MaterialButton
8181
android:id="@+id/menu_direct_camera_upload"
82-
style="@style/Widget.Material3.Button.IconButton"
82+
style="@style/Widget.App.Button.BottomSheetItem"
8383
android:layout_width="match_parent"
8484
android:layout_height="@dimen/bottom_sheet_item_height"
8585
android:contentDescription="@string/upload_direct_camera_upload"
@@ -97,7 +97,7 @@
9797

9898
<com.google.android.material.button.MaterialButton
9999
android:id="@+id/menu_scan_doc_upload"
100-
style="@style/Widget.Material3.Button.IconButton"
100+
style="@style/Widget.App.Button.BottomSheetItem"
101101
android:layout_width="match_parent"
102102
android:layout_height="@dimen/bottom_sheet_item_height"
103103
android:contentDescription="@string/upload_scan_doc_upload"
@@ -116,7 +116,7 @@
116116

117117
<com.google.android.material.button.MaterialButton
118118
android:id="@+id/menu_mkdir"
119-
style="@style/Widget.Material3.Button.IconButton"
119+
style="@style/Widget.App.Button.BottomSheetItem"
120120
android:layout_width="match_parent"
121121
android:layout_height="@dimen/bottom_sheet_item_height"
122122
android:contentDescription="@string/create_new_folder"
@@ -134,7 +134,7 @@
134134

135135
<com.google.android.material.button.MaterialButton
136136
android:id="@+id/menu_new_document"
137-
style="@style/Widget.Material3.Button.IconButton"
137+
style="@style/Widget.App.Button.BottomSheetItem"
138138
android:layout_width="match_parent"
139139
android:layout_height="@dimen/bottom_sheet_item_height"
140140
android:contentDescription="@string/create_new_document"
@@ -152,7 +152,7 @@
152152

153153
<com.google.android.material.button.MaterialButton
154154
android:id="@+id/menu_new_spreadsheet"
155-
style="@style/Widget.Material3.Button.IconButton"
155+
style="@style/Widget.App.Button.BottomSheetItem"
156156
android:layout_width="match_parent"
157157
android:layout_height="@dimen/bottom_sheet_item_height"
158158
android:contentDescription="@string/create_new_spreadsheet"
@@ -170,7 +170,7 @@
170170

171171
<com.google.android.material.button.MaterialButton
172172
android:id="@+id/menu_new_presentation"
173-
style="@style/Widget.Material3.Button.IconButton"
173+
style="@style/Widget.App.Button.BottomSheetItem"
174174
android:layout_width="match_parent"
175175
android:layout_height="@dimen/bottom_sheet_item_height"
176176
android:contentDescription="@string/create_new_presentation"
@@ -205,13 +205,13 @@
205205
android:id="@+id/menu_create_rich_workspace_divider"
206206
android:layout_width="match_parent"
207207
android:layout_height="wrap_content"
208-
android:layout_marginHorizontal="@dimen/bottom_sheet_menu_item_divider_standard_margin"
208+
android:layout_marginStart="@dimen/bottom_sheet_menu_item_divider_standard_margin"
209209
android:layout_marginVertical="@dimen/standard_half_margin"
210210
app:dividerColor="@color/list_divider_background" />
211211

212212
<com.google.android.material.button.MaterialButton
213213
android:id="@+id/menu_create_rich_workspace"
214-
style="@style/Widget.Material3.Button.IconButton"
214+
style="@style/Widget.App.Button.BottomSheetItem"
215215
android:layout_width="match_parent"
216216
android:layout_height="@dimen/bottom_sheet_item_height"
217217
android:contentDescription="@string/create_rich_workspace"

app/src/main/res/values/dims.xml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
<dimen name="action_bar_margin_top">64dp</dimen>
1818
<dimen name="bottom_sheet_text_start_margin">40dp</dimen>
1919
<dimen name="bottom_sheet_item_height">56dp</dimen>
20-
<dimen name="bottom_sheet_menu_item_divider_standard_margin">80dp</dimen>
20+
<dimen name="bottom_sheet_menu_item_divider_standard_margin">56dp</dimen>
2121
<dimen name="file_icon_size">40dp</dimen>
2222
<dimen name="live_photo_indicator_margin">100dp</dimen>
2323
<dimen name="file_icon_size_grid">128dp</dimen>
@@ -70,7 +70,6 @@
7070
<dimen name="file_list_item_avatar_icon_radius">10dp</dimen>
7171
<dimen name="account_action_layout_height">72dp</dimen>
7272
<dimen name="zero">0dp</dimen>
73-
<dimen name="creator_container_start_padding">20dp</dimen>
7473
<dimen name="iconized_single_line_item_layout_height">56dp</dimen>
7574
<dimen name="iconized_single_line_item_icon_size">24dp</dimen>
7675
<dimen name="user_info_icon_horizontal_margin">24dp</dimen>

app/src/main/res/values/styles.xml

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -426,6 +426,18 @@
426426
<item name="iconPadding">0dp</item>
427427
</style>
428428

429+
<style name="Widget.App.Button.BottomSheetItem" parent="Widget.Material3.Button.TextButton.Icon">
430+
<item name="cornerRadius">0dp</item>
431+
<item name="android:insetTop">0dp</item>
432+
<item name="android:insetBottom">0dp</item>
433+
<item name="backgroundTint">@android:color/transparent</item>
434+
<item name="rippleColor">?attr/colorControlHighlight</item>
435+
</style>
436+
437+
<style name="ThemeOverlay.App.Button.BottomSheetItem" parent="Widget.Material3.Button.IconButton">
438+
<item name="materialButtonStyle">@style/Widget.App.Button.BottomSheetItem</item>
439+
</style>
440+
429441
<style name="Nextcloud.Material.TextButton" parent="Widget.Material3.Button.TextButton.Icon">
430442
<item name="android:typeface">sans</item>
431443
<item name="android:textStyle">bold</item>

0 commit comments

Comments
 (0)