fix ux

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>

Author: alperozturk96

app/src/main/java/com/nextcloud/client/assistant/translate/TranslationScreenState.kt

@@ -21,6 +21,23 @@ sealed class TranslationScreenState(
     open val targetHintMessageId: Int?
 )
 
+data object Uninitialized : TranslationScreenState(
+    taskTypeData = TaskTypeData(null, "", null, mapOf(), mapOf()),
+    source = TranslationSideState(
+        text = "",
+        language = null,
+        isTarget = false
+    ),
+    target = TranslationSideState(
+        text = "",
+        language = null,
+        isTarget = true
+    ),
+    fabVisibility = false,
+    shimmer = false,
+    targetHintMessageId = null
+)
+
 data class NewTranslation(
     override val taskTypeData: TaskTypeData,
     override val source: TranslationSideState,
@@ -117,6 +134,9 @@ fun TranslationScreenState.withShimmer(shimmer: Boolean): TranslationScreenState
     is NewTranslation -> copy(shimmer = shimmer)
     is ExistingTranslation -> copy(shimmer = shimmer)
     is EditedTranslation -> copy(shimmer = shimmer)
+    Uninitialized -> {
+        Uninitialized
+    }
 }
 
 fun TranslationScreenState.withTargetText(text: String): TranslationScreenState = when (this) {
@@ -126,12 +146,18 @@ fun TranslationScreenState.withTargetText(text: String): TranslationScreenState
         target = target.copy(text = text),
         shimmer = shimmer
     )
+
     is ExistingTranslation -> copy(
         target = target.copy(text = text)
     )
+
     is EditedTranslation -> copy(
         target = target.copy(text = text)
     )
+
+    Uninitialized -> {
+        Uninitialized
+    }
 }
 
 fun TranslationScreenState.withSource(newSource: TranslationSideState): TranslationScreenState = when (this) {
@@ -142,18 +168,27 @@ fun TranslationScreenState.withSource(newSource: TranslationSideState): Translat
         target = target,
         shimmer = shimmer
     )
+
     is EditedTranslation -> copy(source = newSource)
+    Uninitialized -> {
+        Uninitialized
+    }
 }
 
 fun TranslationScreenState.withTarget(newTarget: TranslationSideState): TranslationScreenState = when (this) {
     is NewTranslation -> {
         copy(target = newTarget)
     }
+
     is ExistingTranslation -> EditedTranslation(
         taskTypeData = taskTypeData,
         source = source,
         target = newTarget,
         shimmer = shimmer
     )
+
     is EditedTranslation -> copy(target = newTarget)
+    Uninitialized -> {
+        Uninitialized
+    }
 }

app/src/main/java/com/nextcloud/client/assistant/translate/TranslationViewModel.kt

@@ -31,7 +31,8 @@ class TranslationViewModel(private val remoteRepository: AssistantRemoteReposito
         private const val MAX_RETRY = 3
     }
 
-    private lateinit var _screenState: MutableStateFlow<TranslationScreenState>
+    private var _screenState =
+        MutableStateFlow<TranslationScreenState>(Uninitialized)
     val screenState: StateFlow<TranslationScreenState>
         get() = _screenState
 
@@ -53,10 +54,6 @@ class TranslationViewModel(private val remoteRepository: AssistantRemoteReposito
         } else {
             val translatedText = task.output?.output ?: ""
             this.translatedText = translatedText
-
-            viewModelScope.launch {
-                pollTranslationResult()
-            }
             MutableStateFlow(ExistingTranslation.create(taskTypeData, textToTranslate, translatedText))
         }
     }
@@ -70,17 +67,12 @@ class TranslationViewModel(private val remoteRepository: AssistantRemoteReposito
 
             val model = taskTypeData.toTranslationModel()
 
-            if (model == null) {
-                updateSnackbarMessage(R.string.translation_screen_error_message)
-                return@launch
-            }
-
             val input = TranslationRequest(
                 input = textToTranslate,
                 originLanguage = originLanguage.code,
                 targetLanguage = targetLanguage.code,
-                maxTokens = model.maxTokens,
-                model = model.model
+                maxTokens = 0.0,
+                model = model?.model ?: ""
             )
 
             val result = remoteRepository.translate(input, taskTypeData)
@@ -92,13 +84,20 @@ class TranslationViewModel(private val remoteRepository: AssistantRemoteReposito
         }
     }
 
+    @Suppress("ReturnCount")
     private suspend fun pollTranslationResult() {
+        val screenStateValue = _screenState.value
+        if (screenStateValue is Uninitialized) {
+            return
+        }
+
         val taskTypeId = taskTypeData.id ?: return
+        val input = screenStateValue.source.text
 
         repeat(MAX_RETRY) { attempt ->
             val translationTasks = remoteRepository.getTaskList(taskTypeId)
             val translationResult = translationTasks
-                ?.find { it.id == task?.id }
+                ?.find { it.input?.input == input }
                 ?.output
                 ?.output
 

app/src/main/res/values/strings.xml

@@ -87,7 +87,6 @@
     <string name="translation_screen_translating">Translating…</string>
     <string name="translation_screen_start_to_translate_task">Press the button to translate</string>
     <string name="translation_screen_hint_source">Enter text to translate…</string>
-    <string name="translation_screen_error_message">Translation model not exists.</string>
     <string name="translation_screen_task_processing">Translation is taking longer than expected.</string>
 
     <!-- Conversation Screen -->