Merge pull request #16600 from nextcloud/fix/foreground-service-did-not-start-in-time

fix(foreground-service): did not start in time exception

Author: alperozturk96

app/src/main/java/com/nextcloud/client/jobs/autoUpload/AutoUploadWorker.kt

@@ -77,6 +77,8 @@ class AutoUploadWorker(
     @Suppress("ReturnCount")
     override suspend fun doWork(): Result {
         return try {
+            trySetForeground()
+
             val syncFolderId = inputData.getLong(SYNCED_FOLDER_ID, -1)
             syncedFolder = syncedFolderProvider.getSyncedFolderByID(syncFolderId)
                 ?.takeIf { it.isEnabled } ?: return Result.failure()
@@ -242,7 +244,6 @@ class AutoUploadWorker(
         val client = OwnCloudClientManagerFactory.getDefaultSingleton()
             .getClientFor(ocAccount, context)
 
-        trySetForeground()
         updateNotification()
 
         var lastId = 0

app/src/main/java/com/nextcloud/client/jobs/download/FileDownloadWorker.kt

@@ -117,7 +117,7 @@ class FileDownloadWorker(
 
         return try {
             setUser()
-            val remotePath = inputData.keyValueMap[FILE_REMOTE_PATH] as String? ?: return Result.failure()
+            val remotePath = inputData.keyValueMap[FILE_REMOTE_PATH] as? String? ?: return Result.failure()
             val ocFile = fileDataStorageManager?.getFileByEncryptedRemotePath(remotePath) ?: return Result.failure()
             val requestDownloads = getRequestDownloads(ocFile)
             addAccountUpdateListener()

app/src/main/java/com/nextcloud/client/jobs/upload/FileUploadWorker.kt

@@ -121,12 +121,12 @@ class FileUploadWorker(
     private val fileUploadBroadcastManager = FileUploadBroadcastManager(localBroadcastManager)
 
     override suspend fun doWork(): Result = try {
+        trySetForeground()
+
         Log_OC.d(TAG, "FileUploadWorker started")
         val workerName = BackgroundJobManagerImpl.formatClassTag(this::class)
         backgroundJobManager.logStartOfWorker(workerName)
 
-        trySetForeground()
-
         val result = uploadFiles()
         backgroundJobManager.logEndOfWorker(workerName, result)
         notificationManager.dismissNotification()