Screenshot tests tooling#16233
Conversation
Flavor was changed in nextcloud#15062, bf46332, from gplay to generic, but not all instances were adjusted. Signed-off-by: Philipp Hasper <vcs@hasper.info>
PhilLab
force-pushed
the
ph/screenshot_tests_tooling
branch
from
aa9c104 to
e1cff4e
Compare
Since 002f61a, the 'shot' dependency is excluded from the normal build, so it requires appropriate preconditions to be executed. Otherwise, the gradle task `genericDebugExecuteScreenshotTests` will not even be available. You can either ensure the appropriate setup manually, or better use the utility scripts. To facilitate the latter, some documentation was added as well. Signed-off-by: Philipp Hasper <vcs@hasper.info>
The AVD setup was only done automatically when executing updateScreenshots.sh. The lines were copied from there, but long-term, the exact AVD configuration as well as emulator parameters should rather be stored somewhere shared. Signed-off-by: Philipp Hasper <vcs@hasper.info>
PhilLab
added
3. to review
documentation
|
Thank you 🎉 |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
4 participants
The existing documentation sent you on the wrong track, as the 'shot' dependency is excluded from the normal build, so it requires appropriate preconditions to be executed. Otherwise, the gradle task
genericDebugExecuteScreenshotTestswill not even be available.