Skip to content

FileDetails: set/unset favorite also via bottom menu#16261

Merged
tobiasKaminsky merged 1 commit into
masterfrom
favoritesInMenu
Apr 15, 2026
Merged

FileDetails: set/unset favorite also via bottom menu#16261
tobiasKaminsky merged 1 commit into
masterfrom
favoritesInMenu

Conversation

@tobiasKaminsky
Copy link
Copy Markdown
Member

  • Tests written, or not not needed

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 9, 2026

Codacy

SpotBugs

CategoryBaseNew
Bad practice4343
Correctness7474
Dodgy code257256
Experimental11
Internationalization77
Malicious code vulnerability33
Multithreaded correctness3434
Performance4444
Security1818
Total481480

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 9, 2026

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16261.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 9, 2026

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

Comment thread app/src/main/java/com/nextcloud/ui/fileactions/FileAction.kt
@tobiasKaminsky
Copy link
Copy Markdown
Member Author

/backport to stable-3.31.0

@tobiasKaminsky tobiasKaminsky merged commit 3c52e2c into master Apr 15, 2026
19 of 22 checks passed
@tobiasKaminsky tobiasKaminsky deleted the favoritesInMenu branch April 15, 2026 07:40
@tobiasKaminsky tobiasKaminsky added this to the Nextcloud App 33.1.0 milestone Apr 15, 2026
@backportbot
Copy link
Copy Markdown

backportbot Bot commented Apr 15, 2026

The backport to stable-3.31.0 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable-3.31.0
git pull origin stable-3.31.0

# Create the new backport branch
git checkout -b backport/16261/stable-3.31.0

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick bea0aa2b

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/16261/stable-3.31.0

Error: Failed to clone repository: Failed to create working tree: Preparing worktree (new branch 'backport/16261/stable-3.31.0')
fatal: not a valid object name: 'origin/stable-3.31.0'


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants