Skip to content

handle oc upload construct#16340

Merged
alperozturk96 merged 3 commits into
masterfrom
handle-oc-upload-construct
Jan 22, 2026
Merged

handle oc upload construct#16340
alperozturk96 merged 3 commits into
masterfrom
handle-oc-upload-construct

Conversation

@alperozturk96

@alperozturk96 alperozturk96 commented Jan 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator
  • Tests written, or not not needed

@alperozturk96
handle oc upload construct
28d4e79 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96 alperozturk96 linked an issue Jan 22, 2026 that may be closed by this pull request
Crash with bulk auto-upload #16328
Closed
4 tasks
@alperozturk96 alperozturk96 added this to the Nextcloud App 3.35.1 milestone Jan 22, 2026
@alperozturk96

alperozturk96 commented Jan 22, 2026

Copy link
Copy Markdown
Collaborator Author

/backport to stable-3.35

@github-actions

github-actions Bot commented Jan 22, 2026

Copy link
Copy Markdown

Codacy

SpotBugs

CategoryBaseNew
Bad practice4343
Correctness7474
Dodgy code256256
Experimental11
Internationalization77
Malicious code vulnerability33
Multithreaded correctness3434
Performance4343
Security1818
Total479479

ZetaTom
ZetaTom reviewed Jan 22, 2026
View reviewed changes

@ZetaTom ZetaTom left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. I've added some comments which shouldn't affect the control flow.

Comment thread app/src/main/java/com/nextcloud/client/database/entity/UploadEntity.kt Outdated
Comment thread app/src/main/java/com/nextcloud/client/jobs/autoUpload/AutoUploadWorker.kt Outdated
alperozturk96 and others added 2 commits January 22, 2026 15:51
@alperozturk96 @ZetaTom
Apply suggestion from @ZetaTom
e300fb8 
Co-authored-by: Tom <70907959+ZetaTom@users.noreply.github.com>
Signed-off-by: Alper Öztürk <67455295+alperozturk96@users.noreply.github.com>
@alperozturk96 @ZetaTom
Apply suggestion from @ZetaTom
481b7c3 
Co-authored-by: Tom <70907959+ZetaTom@users.noreply.github.com>
Signed-off-by: Alper Öztürk <67455295+alperozturk96@users.noreply.github.com>
@alperozturk96 alperozturk96 merged commit 6ff0db5 into master Jan 22, 2026
9 of 17 checks passed
@alperozturk96 alperozturk96 deleted the handle-oc-upload-construct branch January 22, 2026 14:53
@backportbot backportbot Bot mentioned this pull request Jan 22, 2026
Merged
@github-actions

github-actions Bot commented Jan 22, 2026

Copy link
Copy Markdown

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@github-actions

github-actions Bot commented Jan 22, 2026

Copy link
Copy Markdown

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16340.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZetaTom ZetaTom ZetaTom left review comments

@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

Assignees

No one assigned

Labels

3. to review

Projects

None yet

Milestone

Nextcloud App 3.35.1

Development

Successfully merging this pull request may close these issues.

Crash with bulk auto-upload

2 participants

@alperozturk96 @ZetaTom