Skip to content

fix(rich documents): download as#17083

Merged
tobiasKaminsky merged 6 commits into
masterfrom
fix/rich-documents-file-download
Jun 3, 2026
Merged

fix(rich documents): download as#17083
tobiasKaminsky merged 6 commits into
masterfrom
fix/rich-documents-file-download

Conversation

@alperozturk96

@alperozturk96 alperozturk96 commented May 22, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@alperozturk96 alperozturk96 linked an issue May 22, 2026 that may be closed by this pull request
[RichDocuments] downloadAs JSON key mismatch - file download fails with Collabora Online #17076
Closed
@alperozturk96 alperozturk96 added this to the Nextcloud App 34.0.0 milestone May 22, 2026
@github-actions

github-actions Bot commented May 22, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/26287160781/artifacts/7160338242
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@alperozturk96 alperozturk96 requested a review from chrip May 22, 2026 12:29
@github-actions

github-actions Bot commented May 22, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/26287915004/artifacts/7160679692
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

chrip
chrip approved these changes May 26, 2026
View reviewed changes

@chrip chrip left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good extraction of parsing logic with solid test coverage.

@alperozturk96 alperozturk96 force-pushed the fix/rich-documents-file-download branch from 2f8eb27 to 5c866f4 Compare June 2, 2026 13:01
@github-actions

github-actions Bot commented Jun 2, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/26821444442/artifacts/7358827363
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@alperozturk96
wip
94f0283 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
wip
b31060e 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
wip
0b15a1b 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
wip
7e28302 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
wip
412e0ee 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96 alperozturk96 force-pushed the fix/rich-documents-file-download branch from 5c866f4 to 412e0ee Compare June 3, 2026 05:43
@alperozturk96
wip
635d57a 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown

Codacy

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness6767
Dodgy code216216
Experimental11
Internationalization77
Malicious code vulnerability22
Multithreaded correctness3434
Performance4242
Security1616
Total420420

@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/26866365199/artifacts/7376975412
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@tobiasKaminsky tobiasKaminsky merged commit ac67a4a into master Jun 3, 2026
16 of 21 checks passed
@tobiasKaminsky tobiasKaminsky deleted the fix/rich-documents-file-download branch June 3, 2026 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chrip chrip chrip approved these changes
@tobiasKaminsky tobiasKaminsky tobiasKaminsky approved these changes

Assignees

No one assigned

Labels

3. to review

Projects

None yet

Milestone

Nextcloud App 34.0.0

Development

Successfully merging this pull request may close these issues.

[RichDocuments] downloadAs JSON key mismatch - file download fails with Collabora Online

3 participants

@alperozturk96 @chrip @tobiasKaminsky