Skip to content

test: cover filename extension helpers#17088

Open
sgallese wants to merge 2 commits into
nextcloud:masterfrom
sgallese:mal/nextcloud-string-extension-baseline
Open

test: cover filename extension helpers#17088
sgallese wants to merge 2 commits into
nextcloud:masterfrom
sgallese:mal/nextcloud-string-extension-baseline

Conversation

@sgallese

Copy link
Copy Markdown

Summary

  • Add unit coverage for filename extension edge cases.
  • Cover multi-extension, hidden-file, and trailing-dot behavior.

Testing

  • ./gradlew --no-daemon testGplayDebugUnitTest --tests com.nextcloud.android.utils.ExtensionsTest --rerun-tasks
  • ./gradlew --no-daemon spotlessKotlinCheck

Screenshots

Not applicable, test-only change.

Checklist

  • Tests written, or not not needed

Add direct unit coverage for filename extension edge cases in the Kotlin string extension helpers.

AI-assistant: Codex (GPT-5)
Signed-off-by: Sebastian Gallese <140911+sgallese@users.noreply.github.com>
@github-actions

github-actions Bot commented Jun 7, 2026

Copy link
Copy Markdown

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@alperozturk96 alperozturk96 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tobiasKaminsky Locally tested works but Unit Test is not running, fyi.

@sgallese

Copy link
Copy Markdown
Author

Looks like Codecov upload step is failing on CI (gpg: Can't check signature: No public key) but the unit tests are passing.

Seeing this error on a few other PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants