Skip to content

improve upload cancellation#17095

Merged
alperozturk96 merged 6 commits into
masterfrom
fix/upload-cancel
Jun 3, 2026
Merged

improve upload cancellation#17095
alperozturk96 merged 6 commits into
masterfrom
fix/upload-cancel

Conversation

@alperozturk96
Copy link
Copy Markdown
Collaborator

@alperozturk96 alperozturk96 commented May 26, 2026

Changes

  • Preserve user's file selection for upload
  • Remove file if already uploaded after cancel upload
  • Update DB only from UploadFileOperation

Demo

Screen_recording_20260526_153006.mp4

mLocalFolderPicker = localFolderPickerMode;
this.localFileListFragmentInterface = localFileListFragmentInterface;
checkedFiles = new HashSet<>();
checkedFiles = new LinkedHashSet<>();
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preserve user's file selection for upload

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 3, 2026

APK file: https://github.com/nextcloud/android/actions/runs/26867851493/artifacts/7377420342
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 3, 2026

Codacy

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness6767
Dodgy code216217
Experimental11
Internationalization77
Malicious code vulnerability22
Multithreaded correctness3434
Performance4242
Security1616
Total420421

SpotBugs increased!

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 3, 2026

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@alperozturk96 alperozturk96 merged commit cb6f8b9 into master Jun 3, 2026
14 of 20 checks passed
@alperozturk96 alperozturk96 deleted the fix/upload-cancel branch June 3, 2026 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant