fix(files-actions-menu): evict cache after the DB write, not before

Evicting before the write opens a window where a concurrent reader misses
the cache, refetches the still-pre-write DB, and repopulates with stale data
that sticks until the next register/unregister. Also avoids churning the
cache when the write itself throws.

Signed-off-by: Jaap van der Plas <jvdplas@gmail.com>

Author: jvdp

lib/Service/UI/FilesActionsMenuService.php

@@ -67,8 +67,9 @@ public function registerFileActionMenu(string $appId, string $name, string $disp
 			$entity->setOrder($order);
 			$entity->setVersion($version);
 			$entity->setDefaultAction($defaultAction);
+			$result = $existing === null ? $this->mapper->insert($entity) : $this->mapper->update($entity);
 			$this->resetCacheEnabled();
-			return $existing === null ? $this->mapper->insert($entity) : $this->mapper->update($entity);
+			return $result;
 		} catch (Exception $e) {
 			$this->logger->error(
 				sprintf('Failed to register ExApp %s FileActionMenu %s. Error: %s', $appId, $name, $e->getMessage()), ['exception' => $e]