Merge pull request #891 from nextcloud/fix/exapp-fetcher-generic-file-exception

fix(fetcher): catch GenericFileException when reading the appstore cache file

Author: oleksandr-nc

lib/Fetcher/AppAPIFetcher.php

@@ -15,6 +15,7 @@
 use OCA\AppAPI\AppInfo\Application;
 use OCP\AppFramework\Http;
 use OCP\AppFramework\Utility\ITimeFactory;
+use OCP\Files\GenericFileException;
 use OCP\Files\IAppData;
 use OCP\Files\NotFoundException;
 use OCP\Files\NotPermittedException;
@@ -148,6 +149,16 @@ public function get(bool $allowUnstable = false): array {
 		} catch (NotFoundException $e) {
 			// File does not already exists
 			$file = $rootFolder->newFile($this->fileName);
+		} catch (GenericFileException $e) {
+			// File exists but is unreadable (I/O or OS-level permission failure); drop it and refresh
+			try {
+				$file->delete();
+			} catch (Exception) {
+				$this->logger->error('Could not read appstore cache file', ['app' => 'appstoreExAppFetcher', 'exception' => $e]);
+				return [];
+			}
+			$this->logger->warning('Could not read appstore cache file, it will be refreshed', ['app' => 'appstoreExAppFetcher', 'exception' => $e]);
+			$file = $rootFolder->newFile($this->fileName);
 		}
 
 		// Refresh the file content