Skip to content

Commit 873f58e

Browse files
committed
ci: use loglevel 1 in Redis jobs to avoid DI recursion crash on current server master
Signed-off-by: Oleksander Piskun <oleksandr2088@icloud.com>
1 parent 36906ff commit 873f58e

1 file changed

Lines changed: 8 additions & 2 deletions

File tree

.github/workflows/tests-deploy.yml

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -684,7 +684,10 @@ jobs:
684684
./occ maintenance:install --verbose --database=pgsql --database-name=nextcloud --database-host=127.0.0.1 \
685685
--database-port=$DB_PORT --database-user=root --database-pass=rootpassword \
686686
--admin-user admin --admin-pass admin
687-
./occ config:system:set loglevel --value=0 --type=integer
687+
# loglevel 0 currently crashes occ on server master when Redis memcache is configured: the deprecated
688+
# 'RedisFactory' alias logs at debug level, which resolves IRequest mid-DI and recurses infinitely.
689+
# Keep loglevel at 1 here until the server-side fix lands.
690+
./occ config:system:set loglevel --value=1 --type=integer
688691
./occ config:system:set debug --value=true --type=boolean
689692
690693
./occ config:system:set memcache.local --value "\\OC\\Memcache\\Redis"
@@ -826,7 +829,10 @@ jobs:
826829
./occ maintenance:install --verbose --database=pgsql --database-name=nextcloud --database-host=127.0.0.1 \
827830
--database-port=$DB_PORT --database-user=root --database-pass=rootpassword \
828831
--admin-user admin --admin-pass admin
829-
./occ config:system:set loglevel --value=0 --type=integer
832+
# loglevel 0 currently crashes occ on server master when Redis memcache is configured: the deprecated
833+
# 'RedisFactory' alias logs at debug level, which resolves IRequest mid-DI and recurses infinitely.
834+
# Keep loglevel at 1 here until the server-side fix lands.
835+
./occ config:system:set loglevel --value=1 --type=integer
830836
./occ config:system:set debug --value=true --type=boolean
831837
832838
./occ config:system:set memcache.local --value "\\OC\\Memcache\\Redis"

0 commit comments

Comments
 (0)