address review comments

Signed-off-by: Anupam Kumar <kyteinsky@gmail.com>

Author: kyteinsky

lib/Fetcher/ExAppArchiveFetcher.php

@@ -96,19 +96,11 @@ public function installTranslations(string $appId, string $dirTranslations): str
 
 	public function getExAppFolder(string $appId): ?string {
 		$appsPaths = $this->config->getSystemValue('apps_paths', []);
-		$existingPath = '';
-		foreach ($appsPaths as $appPath) {
-			if ($appPath['writable'] && file_exists($appPath['path'] . '/' . $appId)) {
-				$existingPath = $appPath['path'] . '/' . $appId;
-			}
-		}
-		if (!empty($existingPath)) {
-			return $existingPath;
-		}
 		foreach ($appsPaths as $appPath) {
 			if ($appPath['writable']) {
-				if (mkdir($appPath['path'] . '/' . $appId)) {
-					return $appPath['path'] . '/' . $appId;
+				$fullAppPath = $appPath['path'] . '/' . $appId;
+				if (is_dir($fullAppPath) || mkdir($fullAppPath)) {
+					return $fullAppPath;
 				}
 			}
 		}
@@ -131,7 +123,7 @@ public function removeExAppFolder(string $appId): void {
 			return;
 		}
 		foreach ($appsPaths as $appPath) {
-			if ($appPath['writable'] && file_exists($appPath['path'] . '/' . $appId)) {
+			if ($appPath['writable'] && is_dir($appPath['path'] . '/' . $appId)) {
 				$this->rmdirr($appPath['path'] . '/' . $appId);
 			}
 		}