Skip to content

Commit eb1d91f

Browse files
committed
improve InfoTooltip, remove color, show NcDialog on click
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
1 parent 8f2f474 commit eb1d91f

2 files changed

Lines changed: 25 additions & 13 deletions

File tree

src/components/DaemonConfig/InfoTooltip.vue

Lines changed: 21 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -3,25 +3,36 @@
33
- SPDX-License-Identifier: AGPL-3.0-or-later
44
-->
55
<template>
6-
<NcButton
7-
:title="text"
8-
variant="tertiary"
9-
:aria-label="text">
10-
<template #icon>
11-
<component :is="iconComponent" :fill-color="iconColor" :size="20" />
12-
</template>
13-
</NcButton>
6+
<div>
7+
<NcButton
8+
:title="text"
9+
variant="tertiary"
10+
@click="showDialog = true">
11+
<template #icon>
12+
<component :is="iconComponent" :size="20" />
13+
</template>
14+
</NcButton>
15+
<NcDialog v-model:open="showDialog"
16+
:name="t('app_api', 'More information')"
17+
:message="text"
18+
:close-on-click-outside="true"
19+
:out-transition="false"
20+
:container="null" />
21+
</div>
1422
</template>
1523

1624
<script>
17-
import NcButton from '@nextcloud/vue/components/NcButton'
1825
import Warning from 'vue-material-design-icons/AlertOutline.vue'
1926
import Information from 'vue-material-design-icons/InformationOutline.vue'
2027
28+
import NcButton from '@nextcloud/vue/components/NcButton'
29+
import NcDialog from '@nextcloud/vue/components/NcDialog'
30+
2131
export default {
2232
name: 'InfoTooltip',
2333
components: {
2434
NcButton,
35+
NcDialog,
2536
Information,
2637
Warning,
2738
},
@@ -41,15 +52,13 @@ export default {
4152
},
4253
data() {
4354
return {
55+
showDialog: false,
4456
}
4557
},
4658
computed: {
4759
iconComponent() {
4860
return this.type === 'warning' ? Warning : Information
4961
},
50-
iconColor() {
51-
return this.type === 'warning' ? 'var(--color-warning)' : 'var(--color-primary)'
52-
},
5362
},
5463
}
5564
</script>

src/components/DaemonConfig/ManageDaemonConfigModal.vue

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,10 @@
9494
{{ t('app_api', 'Enable HTTPS') }}
9595
</NcFormBoxSwitch>
9696
</NcFormBox>
97-
<NcButton :aria-label="t('app_api', 'Deploy options')" style="margin: 10px 0;" @click="deployConfigSettingsOpened = !deployConfigSettingsOpened">
97+
<NcButton
98+
:aria-label="t('app_api', 'Deploy options')"
99+
style="margin: 10px 0; width: 100%;"
100+
@click="deployConfigSettingsOpened = !deployConfigSettingsOpened">
98101
{{ !deployConfigSettingsOpened ? t('app_api', 'Show deploy options') : t('app_api', 'Hide deploy options') }}
99102
<template #icon>
100103
<UnfoldLessHorizontal v-if="deployConfigSettingsOpened" :size="20" />

0 commit comments

Comments
 (0)