Merge pull request #2346 from nextcloud/artonge/fix/getbyid

fix: Migrate `getById` to `getFirstNodeById`

Author: marcelklehr

lib/Controller/BookmarkController.php

@@ -170,11 +170,11 @@ private function _returnBookmarkAsArray(Bookmark $bookmark): array {
 		if (!isset($array['tags'])) {
 			$array['tags'] = $this->tagMapper->findByBookmark($bookmark->getId());
 		}
-		if ($array['archivedFile'] !== 0) {
-			$results = $this->rootFolder->getById($array['archivedFile']);
-			if (count($results)) {
-				$array['archivedFilePath'] = $results[0]->getPath();
-				$array['archivedFileType'] = $results[0]->getMimePart();
+		if ($array['archivedFile'] !== 0 && $array['archivedFile'] !== null) {
+			$result = $this->rootFolder->getFirstNodeById($array['archivedFile']);
+			if ($result !== null) {
+				$array['archivedFilePath'] = $result->getPath();
+				$array['archivedFileType'] = $result->getMimePart();
 			}
 		}
 		return $array;

lib/Flow/CreateBookmark.php

@@ -134,7 +134,7 @@ public function onEvent(string $eventName, Event $event, IRuleMatcher $ruleMatch
 			$entity = $ruleMatcher->getEntity();
 
 			if ($entity instanceof File) {
-				$node = current($this->rootFolder->getById($entity->exportContextIDs()['nodeId']));
+				$node = $this->rootFolder->getFirstNodeById($entity->exportContextIDs()['nodeId']);
 				if ($node !== null) {
 					$this->handleFile($node, $user);
 				}