Skip to content

Commit 6220d31

Browse files
committed
fix(BookmarksPreviewer): Add generic previewer to previewers list
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
1 parent 8b3348f commit 6220d31

1 file changed

Lines changed: 28 additions & 8 deletions

File tree

lib/Service/BookmarkPreviewer.php

Lines changed: 28 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
use OCA\Bookmarks\Db\Bookmark;
1414
use OCA\Bookmarks\Image;
1515
use OCA\Bookmarks\Service\Previewers\DefaultBookmarkPreviewer;
16+
use OCA\Bookmarks\Service\Previewers\GenericUrlBookmarkPreviewer;
1617
use OCA\Bookmarks\Service\Previewers\PageresBookmarkPreviewer;
1718
use OCA\Bookmarks\Service\Previewers\ScreeenlyBookmarkPreviewer;
1819
use OCA\Bookmarks\Service\Previewers\ScreenshotMachineBookmarkPreviewer;
@@ -28,6 +29,12 @@ class BookmarkPreviewer implements IBookmarkPreviewer {
2829
* @var string
2930
*/
3031
private $enabled;
32+
33+
/**
34+
* @var FileCache
35+
*/
36+
private $cache;
37+
3138
/**
3239
* @var DefaultBookmarkPreviewer
3340
*/
@@ -37,10 +44,6 @@ class BookmarkPreviewer implements IBookmarkPreviewer {
3744
*/
3845
private $screeenlyPreviewer;
3946

40-
/**
41-
* @var FileCache
42-
*/
43-
private $cache;
4447
/**
4548
* @var Previewers\ScreenshotMachineBookmarkPreviewer
4649
*/
@@ -50,19 +53,30 @@ class BookmarkPreviewer implements IBookmarkPreviewer {
5053
*/
5154
private $pageresPreviewer;
5255

56+
private Previewers\GenericUrlBookmarkPreviewer $genericUrlPreviewer;
57+
5358
/**
5459
* @param IConfig $config
5560
* @param ScreeenlyBookmarkPreviewer $screeenlyPreviewer
5661
* @param DefaultBookmarkPreviewer $defaultPreviewer
5762
* @param FileCache $cache
58-
* @param Previewers\ScreenshotMachineBookmarkPreviewer $screenshotMachinePreviewer
59-
* @param Previewers\PageresBookmarkPreviewer $pageresPreviewer
63+
* @param ScreenshotMachineBookmarkPreviewer $screenshotMachinePreviewer
64+
* @param PageresBookmarkPreviewer $pageresPreviewer
6065
*/
61-
public function __construct(IConfig $config, ScreeenlyBookmarkPreviewer $screeenlyPreviewer, DefaultBookmarkPreviewer $defaultPreviewer, FileCache $cache, ScreenshotMachineBookmarkPreviewer $screenshotMachinePreviewer, PageresBookmarkPreviewer $pageresPreviewer) {
66+
public function __construct(
67+
IConfig $config,
68+
ScreeenlyBookmarkPreviewer $screeenlyPreviewer,
69+
DefaultBookmarkPreviewer $defaultPreviewer,
70+
FileCache $cache,
71+
ScreenshotMachineBookmarkPreviewer $screenshotMachinePreviewer,
72+
PageresBookmarkPreviewer $pageresPreviewer,
73+
GenericUrlBookmarkPreviewer $genericUrlPreviewer,
74+
) {
6275
$this->screeenlyPreviewer = $screeenlyPreviewer;
6376
$this->defaultPreviewer = $defaultPreviewer;
6477
$this->screenshotMachinePreviewer = $screenshotMachinePreviewer;
6578
$this->pageresPreviewer = $pageresPreviewer;
79+
$this->genericUrlPreviewer = $genericUrlPreviewer;
6680

6781
$this->enabled = $config->getAppValue('bookmarks', 'privacy.enableScraping', 'false');
6882
$this->cache = $cache;
@@ -85,7 +99,13 @@ public function getImage($bookmark, $cacheOnly = false): ?IImage {
8599
return null;
86100
}
87101

88-
$previewers = [$this->screeenlyPreviewer, $this->screenshotMachinePreviewer, $this->pageresPreviewer, $this->defaultPreviewer];
102+
$previewers = [
103+
$this->screeenlyPreviewer,
104+
$this->screenshotMachinePreviewer,
105+
$this->pageresPreviewer,
106+
$this->genericUrlPreviewer,
107+
$this->defaultPreviewer,
108+
];
89109
foreach ($previewers as $previewer) {
90110
$key = $previewer::CACHE_PREFIX . '-' . md5($bookmark->getUrl());
91111
// Try cache first

0 commit comments

Comments
 (0)