Merge pull request #2366 from nextcloud/perf/insert-cache-bm-count

perf(BookmarkMapper): Cache bookmark count

Author: marcelklehr

lib/Db/BookmarkMapper.php

@@ -76,6 +76,9 @@ class BookmarkMapper extends QBMapper {
 	 */
 	private $shareMapper;
 
+	/** @var array<string,int> */
+	private array $userBookmarkCount = [];
+
 	/**
 	 * BookmarkMapper constructor.
 	 *
@@ -155,6 +158,9 @@ public function deleteAll(string $userId): void {
 			$bm = $this->find($bookmark);
 			$this->delete($bm);
 		}
+		if (isset($this->userBookmarkCount[$userId])) {
+			$this->userBookmarkCount[$userId] = 0;
+		}
 		$result->closeCursor();
 	}
 
@@ -838,6 +844,9 @@ public function delete(Entity $entity): Bookmark {
 		);
 
 		$returnedEntity = parent::delete($entity);
+		if (isset($this->userBookmarkCount[$entity->getUserId()])) {
+			$this->userBookmarkCount[$entity->getUserId()] -= 1;
+		}
 
 		$id = $entity->getId();
 
@@ -901,6 +910,9 @@ public function insert(Entity $entity): Bookmark {
 
 		try {
 			parent::insert($entityToInsert);
+			if (isset($this->userBookmarkCount[$entityToInsert->getUserId()])) {
+				$this->userBookmarkCount[$entityToInsert->getUserId()] += 1;
+			}
 			$this->eventDispatcher->dispatchTyped(new InsertEvent('bookmark', $entityToInsert->getId()));
 			return $entityToInsert;
 		} catch (Exception $e) {
@@ -946,6 +958,9 @@ public function insertOrUpdate(Entity $entity): Bookmark {
 	 * @throws Exception
 	 */
 	public function countBookmarksOfUser(string $userId) : int {
+		if (isset($this->userBookmarkCount[$userId])) {
+			return $this->userBookmarkCount[$userId];
+		}
 		$qb = $this->db->getQueryBuilder();
 		$qb
 			->select($qb->func()->count('id'))
@@ -957,6 +972,7 @@ public function countBookmarksOfUser(string $userId) : int {
 			$count = 0;
 		}
 		$result->closeCursor();
+		$this->userBookmarkCount[$userId] = (int)$count;
 		return (int)$count;
 	}