fix(BookmarkPreviewer): Do not store guaranteed null responses in cache

marcelklehr · marcelklehr · commit f5a70fc870e7 · 2025-07-11T13:54:31.000+02:00
when cacheOnly === true

Signed-off-by: Marcel Klehr &lt;mklehr@gmx.net&gt;
diff --git a/lib/Service/BookmarkPreviewer.php b/lib/Service/BookmarkPreviewer.php
@@ -99,12 +99,14 @@ public function getImage($bookmark, $cacheOnly = false): ?IImage {
 			} catch (NotFoundException $e) {
 			} catch (NotPermittedException $e) {
 			}
+			if ($cacheOnly) {
+				continue;
+			}
 			$image = $previewer->getImage($bookmark, $cacheOnly);
 			if (isset($image)) {
 				$this->cache->set($key, $image->serialize(), self::CACHE_TTL);
 				return $image;
 			}
-
 			$this->cache->set($key, 'null', self::CACHE_TTL);
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -99,12 +99,14 @@ public function getImage($bookmark, $cacheOnly = false): ?IImage {`
`99`	`99`	`} catch (NotFoundException $e) {`
`100`	`100`	`} catch (NotPermittedException $e) {`
`101`	`101`	`}`
	`102`	`+ if ($cacheOnly) {`
	`103`	`+ continue;`
	`104`	`+ }`
`102`	`105`	`$image = $previewer->getImage($bookmark, $cacheOnly);`
`103`	`106`	`if (isset($image)) {`
`104`	`107`	`$this->cache->set($key, $image->serialize(), self::CACHE_TTL);`
`105`	`108`	`return $image;`
`106`	`109`	`}`
`107`		`-`
`108`	`110`	`$this->cache->set($key, 'null', self::CACHE_TTL);`
`109`	`111`	`}`
`110`	`112`