fix(BookmarksPreviewer): Add generic previewer to previewers list - #2305
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new generic URL previewer into the bookmark previewing pipeline, ensuring URLs without specialized services still get a preview.
- Adds
GenericUrlBookmarkPreviewerto imports and as a constructor dependency - Updates constructor signature, property, and assignment for the new previewer
- Inserts the generic previewer into the
$previewersarray before the default
Comments suppressed due to low confidence (2)
lib/Service/BookmarkPreviewer.php:56
- Add a docblock
@var GenericUrlBookmarkPreviewerabove this property to describe its purpose and maintain consistency with other previewer properties.
private Previewers\GenericUrlBookmarkPreviewer $genericUrlPreviewer;
lib/Service/BookmarkPreviewer.php:65
- Update the constructor docblock to include
@param GenericUrlBookmarkPreviewer $genericUrlPreviewerso the documentation matches the method signature.
*/
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
marcelklehr
force-pushed
the
fix/generic-url-previewer
branch
from
July 9, 2025 11:26
6220d31 to
5a05e12
Compare
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.