Skip to content

Some fixes - #2310

Merged
marcelklehr merged 4 commits into
masterfrom
fix/typesafe-queries
Jul 16, 2025
Merged

Some fixes#2310
marcelklehr merged 4 commits into
masterfrom
fix/typesafe-queries

Conversation

@marcelklehr

Copy link
Copy Markdown
Member

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr
marcelklehr requested a review from Copilot July 16, 2025 13:47

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances type safety for database queries by importing IQueryBuilder and specifying IQueryBuilder::PARAM_INT for positional and named parameters across migrations and mappers. It also improves error handling in TreeMapper::getSubFolders by catching loading exceptions and filtering out failed shares.

  • Imported IQueryBuilder and added PARAM_INT to all createPositionalParameter/createNamedParameter calls
  • Added try/catch around shared-folder loading in TreeMapper and filtered out null entries

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
lib/Migration/Version003000000Date20191123094721.php Added IQueryBuilder import and PARAM_INT for positional parameters in postSchemaChange
lib/Migration/Version000014000Date20181029094721.php Added IQueryBuilder import and PARAM_INT in postSchemaChange
lib/Migration/OrphanedSharesRepairStep.php Added IQueryBuilder import and PARAM_INT for delete queries
lib/Db/TreeMapper.php Specified PARAM_INT in move, added exception handling and filtered null in getSubFolders
lib/Db/TagMapper.php Added IQueryBuilder import and PARAM_INT for tag lookups
lib/Db/SharedFolderMapper.php Added IQueryBuilder import and PARAM_INT for shared-folder queries
lib/Db/ShareMapper.php Added IQueryBuilder import and PARAM_INT for share queries and annotated exceptions
lib/Db/PublicFolderMapper.php Added IQueryBuilder import and PARAM_INT for named parameters
lib/Db/FolderMapper.php Added IQueryBuilder import and PARAM_INT for find and insert operations
lib/Db/BookmarkMapper.php Added IQueryBuilder import and PARAM_INT for bookmark queries
Comments suppressed due to low confidence (2)

lib/Db/SharedFolderMapper.php:222

  • There's a typo in the constant name PARAM_INTy. It should be IQueryBuilder::PARAM_INT.
			->andWhere($qb->expr()->eq('s.type', $qb->createPositionalParameter($type, IQueryBuilder::PARAM_INTy)))

lib/Db/ShareMapper.php:51

  • There is an extra semicolon (;;) at the end of this line. Removing the duplicate semicolon will resolve the syntax error.
			->where($qb->expr()->eq('id', $qb->createPositionalParameter($shareId, IQueryBuilder::PARAM_INT)));;

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr
marcelklehr merged commit bfa1a11 into master Jul 16, 2025
60 of 71 checks passed
@marcelklehr
marcelklehr deleted the fix/typesafe-queries branch July 16, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants