Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
da7ae86 to
654e770
Compare
There was a problem hiding this comment.
This whole file should be moved to cdav-library.
kra-mo
left a comment
There was a problem hiding this comment.
From the design side:
"Select a user" and "Search for a user…" are redundant, it's fine to just have the second if it's baked into the component anyway, so without the title. The input field should also be full-width, and Add should be a primary button.
I wonder why delegation should be its own item in the sidebar instead of just a section in Settings? I'd rather have it just there. And at that point, have + Add delegate be full-width as well.
a80edc4 to
0dd4839
Compare
Signed-off-by: Grigory Vodyanov <scratchx@gmx.com> # Conflicts: # package-lock.json
0dd4839 to
f50f37d
Compare
kra-mo
left a comment
There was a problem hiding this comment.
Looks good from the design side :)
|
Tested. Found error when delegator has a shared calendar |









For #2706