Skip to content

feat: Allow or disallow party crasher#8222

Merged
kesselb merged 1 commit intomainfrom
feat-party-crasher
May 4, 2026
Merged

feat: Allow or disallow party crasher#8222
kesselb merged 1 commit intomainfrom
feat-party-crasher

Conversation

@kesselb
Copy link
Copy Markdown
Contributor

@kesselb kesselb commented Apr 28, 2026

Summary:

Allow or disallow party crasher

CalDAV: nextcloud/server#59988

Todo

  • Only show 34 or newer

Organizer

Screenshot From 2026-04-28 20-58-31

Attendee

Screenshot From 2026-04-28 21-02-53

@kesselb kesselb self-assigned this Apr 28, 2026
@kesselb kesselb added 2. developing Work in progress bug labels Apr 28, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 28, 2026

Codecov Report

❌ Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/store/calendarObjectInstance.js 0.00% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

@SebastianKrupinski
Copy link
Copy Markdown
Contributor

@SebastianKrupinski
Copy link
Copy Markdown
Contributor

Code looks good, have not tested it yet, my only comment would be... is there a better term then "party crushers"? lol. But is not a blocker

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support for the “Party Crasher” setting (X-NC-PARTY-CRASHER) so organizers can allow or disallow invitees adding themselves to the attendee list, with UI intended to be shown only on Nextcloud 34+.

Changes:

  • Extend the event model with a partyCrasher field (default TRUE), including mapping from/to X-NC-PARTY-CRASHER.
  • Add an editor UI selector for the Party Crasher setting (intended to be version-gated).
  • Add a store action to persist the setting onto the underlying event component, plus unit tests.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tests/javascript/unit/models/event.test.js Updates expectations for the new partyCrasher field and adds tests for mapping/copying X-NC-PARTY-CRASHER.
src/views/EditFull.vue Adds Party Crasher property configuration and a PropertySelect control in the full editor UI (version-gated).
src/store/calendarObjectInstance.js Introduces changePartyCrasher action to write X-NC-PARTY-CRASHER to the event component and store state.
src/models/event.js Adds default partyCrasher, maps it from X-NC-PARTY-CRASHER, and copies it when duplicating/updating components.
src/mixins/PropertyMixin.js Registers AccountPlusOutline icon used by the new Party Crasher property.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/views/EditFull.vue Outdated
Comment thread src/store/calendarObjectInstance.js
@ChristophWurst
Copy link
Copy Markdown
Member

is there a better term then "party crushers"? lol. But is not a blocker

I'd go with the Outlook terminology and call it Allow invitation forwarding

nextcloud/server#59988 (review)

AI-assisted: OpenCode (gpt-5.4)

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@kesselb kesselb merged commit 8be4559 into main May 4, 2026
43 checks passed
@kesselb kesselb deleted the feat-party-crasher branch May 4, 2026 15:39
@kesselb
Copy link
Copy Markdown
Contributor Author

kesselb commented May 7, 2026

/backport to stable6.3

@backportbot backportbot Bot added the backport-request A backport was requested for this pull request label May 7, 2026
@backportbot backportbot Bot removed the backport-request A backport was requested for this pull request label May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2. developing Work in progress bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants