Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
Code looks good, have not tested it yet, my only comment would be... is there a better term then "party crushers"? lol. But is not a blocker |
There was a problem hiding this comment.
Pull request overview
Adds support for the “Party Crasher” setting (X-NC-PARTY-CRASHER) so organizers can allow or disallow invitees adding themselves to the attendee list, with UI intended to be shown only on Nextcloud 34+.
Changes:
- Extend the event model with a
partyCrasherfield (defaultTRUE), including mapping from/toX-NC-PARTY-CRASHER. - Add an editor UI selector for the Party Crasher setting (intended to be version-gated).
- Add a store action to persist the setting onto the underlying event component, plus unit tests.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/javascript/unit/models/event.test.js | Updates expectations for the new partyCrasher field and adds tests for mapping/copying X-NC-PARTY-CRASHER. |
| src/views/EditFull.vue | Adds Party Crasher property configuration and a PropertySelect control in the full editor UI (version-gated). |
| src/store/calendarObjectInstance.js | Introduces changePartyCrasher action to write X-NC-PARTY-CRASHER to the event component and store state. |
| src/models/event.js | Adds default partyCrasher, maps it from X-NC-PARTY-CRASHER, and copies it when duplicating/updating components. |
| src/mixins/PropertyMixin.js | Registers AccountPlusOutline icon used by the new Party Crasher property. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
I'd go with the Outlook terminology and call it Allow invitation forwarding |
AI-assisted: OpenCode (gpt-5.4) Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
3b01259 to
156b994
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
/backport to stable6.3 |
Summary:
Allow or disallow party crasher
CalDAV: nextcloud/server#59988
Todo
Organizer
Attendee