fix: nextcloud/calendar#8085 (comment)

Signed-off-by: Grigory Vodyanov <scratchx@gmx.com>

Author: GVodyanov

src/index.js

@@ -578,45 +578,63 @@ export default class DavClient {
 	}
 
 	/**
-	 * Returns the absolute URLs of all write-delegates for a principal.
+	 * Returns the absolute URL of a calendar proxy group for a given principal.
 	 *
-	 * Delegates are members of the principal's calendar-proxy-write group.
+	 * @param {string} principalUrl Absolute URL of the principal
+	 * @param {'write'|'read'} type The proxy group type
+	 * @return {string}
+	 * @private
+	 */
+	_getProxyGroupUrl(principalUrl, type) {
+		return principalUrl.replace(/\/?$/, '') + '/calendar-proxy-' + type
+	}
+
+	/**
+	 * Returns the absolute URLs of all delegates for a principal, separated by permission level.
 	 *
-	 * @param {string} proxyWriteGroupUrl Absolute URL of the principal's calendar-proxy-write group
-	 * @return {Promise<string[]>} Absolute principal URLs of delegates
+	 * @param {string} principalUrl Absolute URL of the principal
+	 * @return {Promise<{write: string[], read: string[]}>} Absolute principal URLs of delegates
 	 */
-	async getDelegateUrls(proxyWriteGroupUrl) {
-		return this.getGroupMemberSet(proxyWriteGroupUrl)
+	async getDelegatesForPrincipal(principalUrl) {
+		const [write, read] = await Promise.all([
+			this.getGroupMemberSet(this._getProxyGroupUrl(principalUrl, 'write')),
+			this.getGroupMemberSet(this._getProxyGroupUrl(principalUrl, 'read')),
+		])
+		return { write, read }
 	}
 
 	/**
-	 * Adds a delegate to a calendar-proxy-write group.
+	 * Adds a delegate to a principal's calendar-proxy group.
 	 *
 	 * Fetches the current member set and appends the new delegate if not already present.
 	 *
-	 * @param {string} proxyWriteGroupUrl Absolute URL of the principal's calendar-proxy-write group
+	 * @param {string} ownerPrincipalUrl Absolute URL of the principal who owns the proxy group
 	 * @param {string} delegatePrincipalUrl Absolute or relative URL of the principal to add as delegate
+	 * @param {'write'|'read'} [permission='write'] The proxy group to add the delegate to
 	 * @return {Promise<void>}
 	 */
-	async addDelegate(proxyWriteGroupUrl, delegatePrincipalUrl) {
+	async addDelegate(ownerPrincipalUrl, delegatePrincipalUrl, permission = 'write') {
+		const proxyGroupUrl = this._getProxyGroupUrl(ownerPrincipalUrl, permission)
 		const normalizedUrl = this._request.absoluteUrl(delegatePrincipalUrl)
-		const current = await this.getGroupMemberSet(proxyWriteGroupUrl)
+		const current = await this.getGroupMemberSet(proxyGroupUrl)
 		if (!current.includes(normalizedUrl)) {
-			await this.setGroupMemberSet(proxyWriteGroupUrl, [...current, normalizedUrl])
+			await this.setGroupMemberSet(proxyGroupUrl, [...current, normalizedUrl])
 		}
 	}
 
 	/**
-	 * Removes a delegate from a calendar-proxy-write group.
+	 * Removes a delegate from a principal's calendar-proxy group.
 	 *
-	 * @param {string} proxyWriteGroupUrl Absolute URL of the principal's calendar-proxy-write group
+	 * @param {string} ownerPrincipalUrl Absolute URL of the principal who owns the proxy group
 	 * @param {string} delegatePrincipalUrl Absolute or relative URL of the principal to remove
+	 * @param {'write'|'read'} [permission='write'] The proxy group to remove the delegate from
 	 * @return {Promise<void>}
 	 */
-	async removeDelegate(proxyWriteGroupUrl, delegatePrincipalUrl) {
+	async removeDelegate(ownerPrincipalUrl, delegatePrincipalUrl, permission = 'write') {
+		const proxyGroupUrl = this._getProxyGroupUrl(ownerPrincipalUrl, permission)
 		const normalizedUrl = this._request.absoluteUrl(delegatePrincipalUrl)
-		const current = await this.getGroupMemberSet(proxyWriteGroupUrl)
-		await this.setGroupMemberSet(proxyWriteGroupUrl, current.filter((url) => url !== normalizedUrl))
+		const current = await this.getGroupMemberSet(proxyGroupUrl)
+		await this.setGroupMemberSet(proxyGroupUrl, current.filter((url) => url !== normalizedUrl))
 	}
 
 	/**