refactor: simplify expiration date handling in share methods

- Remove redundant if/else checks since getExpirationDate() returns null
- Add setExpirationDate() in createShare() to reflect auto-applied
expiry dates

Signed-off-by: Silver <s.szmajduch@posteo.de>

Author: silverkszlo

lib/Service/CollectiveShareService.php

@@ -125,11 +125,7 @@ public function findShare(string $userId, int $collectiveId, int $pageId): ?Coll
 			$collectiveShare->setPassword($folderShare->getPassword());
 		}
 
-		if ($folderShare->getExpirationDate()) {
-			$collectiveShare->setExpirationDate($folderShare->getExpirationDate());
-		} else {
-			$collectiveShare->setExpirationDate(null);
-		}
+		$collectiveShare->setExpirationDate($folderShare->getExpirationDate());
 		return $collectiveShare;
 	}
 
@@ -157,11 +153,7 @@ public function findShareByToken(string $token, bool $getPermissionInfo = true):
 			$collectiveShare->setPassword($folderShare->getPassword());
 		}
 
-		if ($folderShare->getExpirationDate()) {
-			$collectiveShare->setExpirationDate($folderShare->getExpirationDate());
-		} else {
-			$collectiveShare->setExpirationDate(null);
-		}
+		$collectiveShare->setExpirationDate($folderShare->getExpirationDate());
 		return $collectiveShare;
 	}
 
@@ -181,12 +173,7 @@ public function getSharesByCollectiveAndUser(string $userId, int $collectiveId):
 				$share->setPassword($folderShare->getPassword());
 			}
 
-			$expirationDate = $folderShare->getExpirationDate();
-			if ($expirationDate) {
-				$share->setExpirationDate($expirationDate);
-			} else {
-				$share->setExpirationDate(null);
-			}
+			$share->setExpirationDate($folderShare->getExpirationDate());
 			$shares[] = $share;
 		}
 
@@ -238,6 +225,7 @@ public function createShare(string $userId, Collective $collective, ?PageInfo $p
 		if ($password != '') {
 			$collectiveShare->setPassword($folderShare->getPassword());
 		}
+		$collectiveShare->setExpirationDate($folderShare->getExpirationDate());
 		return $collectiveShare;
 	}
 
@@ -297,11 +285,7 @@ public function updateShare(string $userId, Collective $collective, ?PageInfo $p
 		$share->setEditable($this->isShareEditable($folderShare));
 		$share->setPassword($folderShare->getPassword() ?? '');
 
-		if ($folderShare->getExpirationDate()) {
-			$share->setExpirationDate($folderShare->getExpirationDate());
-		} else {
-			$share->setExpirationDate(null);
-		}
+		$share->setExpirationDate($folderShare->getExpirationDate());
 
 		return $share;
 	}