fix(router): refactor the generating of a contact key

Code proposed by @cristianscheid

Signed-off-by: silver <s.szmajduch@posteo.de>

Author: silverkszlo

src/models/contact.js

@@ -28,6 +28,10 @@ export const MinimalContactProperties = [
 	'EMAIL', 'UID', 'TEL', 'CATEGORIES', 'FN', 'ORG', 'N', 'X-PHONETIC-FIRST-NAME', 'X-PHONETIC-LAST-NAME', 'X-MANAGERSNAME', 'TITLE', 'NOTE', 'RELATED',
 ].concat(ContactKindProperties)
 
+export function generateContactKey(uid, addressbookId) {
+	return Buffer.from(uid + '~' + addressbookId, 'utf8').toString('base64')
+}
+
 export default class Contact {
 	/**
 	 * Creates an instance of Contact
@@ -211,7 +215,7 @@ export default class Contact {
 	 * @memberof Contact
 	 */
 	get key() {
-		return Buffer.from(this.uid + '~' + this.addressbook.id, 'utf8').toString('base64')
+		return generateContactKey(this.uid, this.addressbook.id)
 	}
 
 	/**

src/router/index.js

@@ -4,10 +4,10 @@
  */
 
 import { generateUrl } from '@nextcloud/router'
-import { Buffer } from 'buffer'
 import { createRouter, createWebHistory } from 'vue-router'
 import Contacts from '../views/Contacts.vue'
 import { GROUP_ALL_CONTACTS, ROUTE_CHART, ROUTE_CIRCLE, ROUTE_USER_GROUP } from '../models/constants.ts'
+import { generateContactKey } from '../models/contact.js'
 
 // if index.php is in the url AND we got this far, then it's working:
 // let's keep using index.php in the url
@@ -65,7 +65,7 @@ export default createRouter({
 						name: 'contact',
 						params: {
 							selectedGroup: GROUP_ALL_CONTACTS,
-							selectedContact: Buffer.from(`${to.params.userId}~z-server-generated--system`, 'utf8').toString('base64'),
+							selectedContact: generateContactKey(to.params.userId, 'z-server-generated--system'),
 						},
 					}),
 				},