Skip to content

feat: Improve circle mobile experience #5163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pymnh wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: Improve circle mobile experience #5163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8989938
feat: Move team preferences to unified NcAppSettingsDialog
pymnh Mar 6, 2026
b896812
fix: Improve mobile view for circles page
pymnh Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 26 additions & 1 deletion src/components/AppNavigation/CircleNavigationItem.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,20 @@
v-if="circle.canManageMembers"
:close-after-click="true"
@click="addMemberToCircle">
<template #icon>
<AccountPlusIcon :size="20" />
</template>
{{ t('contacts', 'Add members') }}
</ActionButton>

<ActionButton
v-if="canManageTeam"
:close-after-click="true"
@click="showSettings = true">
<template #icon>
<IconCog :size="20" />
</template>
{{ t('contacts', 'Manage team') }}
{{ t('contacts', 'Manage settings') }}
</ActionButton>

<!-- copy circle link -->
Expand Down Expand Up @@ -76,6 +86,7 @@
:count="memberCount" />
</template>
</AppNavigationItem>
<CircleSettings v-model:open="showSettings" :circle="circle" />
</template>

<script>
Expand All @@ -88,11 +99,13 @@ import {
NcCounterBubble,
} from '@nextcloud/vue'
import AccountGroupOutline from 'vue-material-design-icons/AccountGroupOutline.vue'
import AccountPlusIcon from 'vue-material-design-icons/AccountPlusOutline.vue'
import AccountStar from 'vue-material-design-icons/AccountStarOutline.vue'
import IconCog from 'vue-material-design-icons/CogOutline.vue'
import ExitToApp from 'vue-material-design-icons/ExitToApp.vue'
import LocationEnter from 'vue-material-design-icons/LocationEnter.vue'
import IconDelete from 'vue-material-design-icons/TrashCanOutline.vue'
import CircleSettings from '../CircleDetails/CircleSettings.vue'
import CircleActionsMixin from '../../mixins/CircleActionsMixin.js'
import Circle from '../../models/circle.ts'
import UserGroup from '../../models/userGroup.ts'
Expand All @@ -104,6 +117,7 @@ export default {
ActionButton,
ActionLink,
ActionText,
CircleSettings,
NcCounterBubble,
AppNavigationItem,
ExitToApp,
Expand All @@ -112,6 +126,7 @@ export default {
LocationEnter,
AccountStar,
AccountGroupOutline,
AccountPlusIcon,
IconLoading,
},

Expand All @@ -124,7 +139,17 @@ export default {
},
},

data() {
return {
showSettings: false,
}
},

computed: {
canManageTeam() {
return (this.circle.isOwner || this.circle.isAdmin) && !this.circle.isPersonal
},

memberCount() {
return this.circle.populationInherited || 0
},
Expand Down
Loading
Loading