Skip to content

fix(router): redirect profile details view to internal contacts list#5556

Merged
hamza221 merged 2 commits into
mainfrom
fix/navigate-to-userprofile
Jul 15, 2026
Merged

fix(router): redirect profile details view to internal contacts list#5556
hamza221 merged 2 commits into
mainfrom
fix/navigate-to-userprofile

Conversation

@silverkszlo

@silverkszlo silverkszlo commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Fixes #5554

The bug

When inside the Contacts app one goes to > Teams > some team > some member > "View profile", the user does not get navigated to the clicked user's profile but to the general "All contacts" list and the following errors appear:
Screenshot from 2026-07-09 08-56-10

What seems to be the cause

  • The "View profile" link is generated server-side and used by NcAvatar. And NcAvatar only checks if the link matches any route in the current app's router.
  • Contacts app's router uses :selectedGroup/:selectedContact with no literal prefix, so it matches any two-segment path and treats /u/alice like an internal path (but it's not)
  • To navigate to the Contact's internal contacts list it should navigate to cloud.host.com/apps/contacts/All%20contacts/[someLongbase64String]
Screenshot from 2026-07-09 09-30-44

The solution

  • Add a profile-redirect in Contacts app's router for u/:userId and build the correct url

That solution seems like a workaround though. Maybe :selectedGroup/:selectedContact should be less permissive or the NcAvatar needs an adjustment?

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@codecov

codecov Bot commented Jul 9, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/models/contact.js 0.00% 3 Missing ⚠️
src/router/index.js 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@silverkszlo silverkszlo force-pushed the fix/navigate-to-userprofile branch from ffa501a to 3bb2f91 Compare July 9, 2026 07:36
@ChristophWurst ChristophWurst added the feature: teams ex circles label Jul 9, 2026
Comment thread src/router/index.js Outdated
Signed-off-by: silver <s.szmajduch@posteo.de>

Assisted-by: ClaudeCode:claude-sonnet-5
Code proposed by @cristianscheid

Signed-off-by: silver <s.szmajduch@posteo.de>
@silverkszlo silverkszlo force-pushed the fix/navigate-to-userprofile branch from 3bb2f91 to 812eeb7 Compare July 14, 2026 06:39
@hamza221

Copy link
Copy Markdown
Contributor

/backport to stable8.7

@hamza221 hamza221 merged commit 17d7a3f into main Jul 15, 2026
36 of 38 checks passed
@hamza221 hamza221 deleted the fix/navigate-to-userprofile branch July 15, 2026 12:07
@hamza221

Copy link
Copy Markdown
Contributor

/backport to stable8.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: teams ex circles

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"View profile" for team members is broken

4 participants