Skip to content

feat: Stream output text and tool calls#183

Merged
marcelklehr merged 5 commits into
mainfrom
feat/streaming
Jun 17, 2026
Merged

feat: Stream output text and tool calls#183
marcelklehr merged 5 commits into
mainfrom
feat/streaming

Conversation

@marcelklehr

@marcelklehr marcelklehr commented Jun 10, 2026

Copy link
Copy Markdown
Member
  • Stream text content
  • Stream tool calls
  • CI test
  • Tested manually

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@julien-nc julien-nc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my tests, an empty string output is reported multiple times before actually getting some text. This makes the message animated placeholder disappear.

Maybe something could be changed in the assistant to prevent that. I think it would be good if context_agent would not report empty output strings as well. Wdyt?

Otherwise, works like a charm!

@marcelklehr

Copy link
Copy Markdown
Member Author

an empty string output is reported multiple times before actually getting some text.

Is it maybe calling tools?

@marcelklehr

Copy link
Copy Markdown
Member Author

Is it maybe calling tools?

That was it

@marcelklehr

Copy link
Copy Markdown
Member Author

CI changes depend on nextcloud/llm2#253 to pass

Assisted-by: Copilot:gpt-5.4
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>

@julien-nc julien-nc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if it's a context_agent or assistant issue but i get the list of all the tools that were used in the conversation. Not just the ones used to produce the message. Is it intended?

Image

@marcelklehr

Copy link
Copy Markdown
Member Author

Nope, I thought I had fixed this. Are you on the latest commit?

@julien-nc

Copy link
Copy Markdown
Member

Yep, last commit. To reproduce, just create a new conversation, ask 2 things (in 2 separate messages) that require tools. The tool list of the second answer includes the tools that were used for the first answer.

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr

Copy link
Copy Markdown
Member Author

Fixed

@julien-nc julien-nc self-requested a review June 17, 2026 13:56

@julien-nc julien-nc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm

@marcelklehr marcelklehr merged commit 3245d97 into main Jun 17, 2026
9 of 10 checks passed
@marcelklehr marcelklehr deleted the feat/streaming branch June 17, 2026 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants