Skip to content

Commit f44eada

Browse files
authored
chore: update workflows from templates (#59)
This PR was automatically generated by the workflow dispatcher Please check that there are no reverted changes before merging ⚠ See templates in https://github.com/nextcloud/.github
2 parents 1e4ba49 + f5f955b commit f44eada

2 files changed

Lines changed: 14 additions & 14 deletions

File tree

.github/workflows/appstore-build-publish.yml

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ jobs:
3232
echo "APP_VERSION=${GITHUB_REF##*/}" >> $GITHUB_ENV
3333
3434
- name: Checkout
35-
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
35+
uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
3636
with:
3737
path: ${{ env.APP_NAME }}
3838

@@ -44,7 +44,7 @@ jobs:
4444
expression: "//info//dependencies//nextcloud/@min-version"
4545

4646
- name: Read package.json node and npm engines version
47-
uses: skjnldsv/read-package-engines-version-actions@8205673bab74a63eb9b8093402fd9e0e018663a1 # v2.2
47+
uses: skjnldsv/read-package-engines-version-actions@06d6baf7d8f41934ab630e97d9e6c0bc9c9ac5e4 # v3
4848
id: versions
4949
# Continue if no package.json
5050
continue-on-error: true
@@ -56,14 +56,14 @@ jobs:
5656
- name: Set up node ${{ steps.versions.outputs.nodeVersion }}
5757
# Skip if no package.json
5858
if: ${{ steps.versions.outputs.nodeVersion }}
59-
uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v3
59+
uses: actions/setup-node@1e60f620b9541d16bece96c5465dc8ee9832be0b # v4.0.3
6060
with:
6161
node-version: ${{ steps.versions.outputs.nodeVersion }}
6262

6363
- name: Set up npm ${{ steps.versions.outputs.npmVersion }}
6464
# Skip if no package.json
6565
if: ${{ steps.versions.outputs.npmVersion }}
66-
run: npm i -g npm@"${{ steps.versions.outputs.npmVersion }}"
66+
run: npm i -g 'npm@${{ steps.versions.outputs.npmVersion }}'
6767

6868
- name: Get php version
6969
id: php-versions
@@ -72,7 +72,7 @@ jobs:
7272
filename: ${{ env.APP_NAME }}/appinfo/info.xml
7373

7474
- name: Set up php ${{ steps.php-versions.outputs.php-min }}
75-
uses: shivammathur/setup-php@a4e22b60bbb9c1021113f2860347b0759f66fe5d # v2
75+
uses: shivammathur/setup-php@c541c155eee45413f5b09a52248675b1a2575231 # v2.31.1
7676
with:
7777
php-version: ${{ steps.php-versions.outputs.php-min }}
7878
coverage: none
@@ -81,7 +81,7 @@ jobs:
8181

8282
- name: Check composer.json
8383
id: check_composer
84-
uses: andstor/file-existence-action@076e0072799f4942c8bc574a82233e1e4d13e9d6 # v2
84+
uses: andstor/file-existence-action@076e0072799f4942c8bc574a82233e1e4d13e9d6 # v3.0.0
8585
with:
8686
files: "${{ env.APP_NAME }}/composer.json"
8787

@@ -99,11 +99,11 @@ jobs:
9999
run: |
100100
cd ${{ env.APP_NAME }}
101101
npm ci
102-
npm run build
102+
npm run build --if-present
103103
104104
- name: Check Krankerl config
105105
id: krankerl
106-
uses: andstor/file-existence-action@076e0072799f4942c8bc574a82233e1e4d13e9d6 # v2
106+
uses: andstor/file-existence-action@076e0072799f4942c8bc574a82233e1e4d13e9d6 # v3.0.0
107107
with:
108108
files: ${{ env.APP_NAME }}/krankerl.toml
109109

@@ -129,12 +129,12 @@ jobs:
129129
continue-on-error: true
130130
id: server-checkout
131131
run: |
132-
NCVERSION=${{ fromJSON(steps.appinfo.outputs.result).nextcloud.min-version }}
132+
NCVERSION='${{ fromJSON(steps.appinfo.outputs.result).nextcloud.min-version }}'
133133
wget --quiet https://download.nextcloud.com/server/releases/latest-$NCVERSION.zip
134134
unzip latest-$NCVERSION.zip
135135
136136
- name: Checkout server master fallback
137-
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
137+
uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
138138
if: ${{ steps.server-checkout.outcome != 'success' }}
139139
with:
140140
submodules: true
@@ -148,7 +148,7 @@ jobs:
148148
tar -xvf ${{ env.APP_NAME }}.tar.gz
149149
cd ../../../
150150
# Setting up keys
151-
echo "${{ secrets.APP_PRIVATE_KEY }}" > ${{ env.APP_NAME }}.key
151+
echo '${{ secrets.APP_PRIVATE_KEY }}' > ${{ env.APP_NAME }}.key
152152
wget --quiet "https://github.com/nextcloud/app-certificate-requests/raw/master/${{ env.APP_NAME }}/${{ env.APP_NAME }}.crt"
153153
# Signing
154154
php nextcloud/occ integrity:sign-app --privateKey=../${{ env.APP_NAME }}.key --certificate=../${{ env.APP_NAME }}.crt --path=../${{ env.APP_NAME }}/build/artifacts/${{ env.APP_NAME }}

.github/workflows/pr-feedback.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ jobs:
3535
with:
3636
feedback-message: |
3737
Hello there,
38-
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.
38+
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.
3939
4040
We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.
4141
@@ -45,6 +45,6 @@ jobs:
4545
4646
(If you believe you should not receive this message, you can add yourself to the [blocklist](https://github.com/nextcloud/.github/blob/master/non-community-usernames.txt).)
4747
days-before-feedback: 14
48-
start-date: "2024-04-30"
49-
exempt-authors: "${{ steps.blocklist.outputs.blocklist }},${{ steps.scrape.outputs.users }},nextcloud-command,nextcloud-android-bot"
48+
start-date: '2024-04-30'
49+
exempt-authors: '${{ steps.blocklist.outputs.blocklist }},${{ steps.scrape.outputs.users }}'
5050
exempt-bots: true

0 commit comments

Comments
 (0)