chore: improve integration test#170
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request refines the integration test workflow by updating trigger conditions, enhancing the path filter job, and adding a summary job for improved status reporting.
- Updated pull request and push triggers to use branch filtering
- Added a "changes" job to detect modified files and conditionally run subsequent jobs
- Introduced a "summary" job to enforce overall integration test status
Comments suppressed due to low confidence (3)
.github/workflows/integration-test.yml:8
- [nitpick] The branch 'master' is used as a trigger; if your repository default is 'main', please verify that this selection is intentional.
branches:
- master
.github/workflows/integration-test.yml:218
- [nitpick] The grep condition is highly specific to a hardcoded message, which might fail if the output message format changes. Consider using a more flexible check or extracting the expected pattern to a variable.
./occ context_chat:prompt admin "Which factors are taken into account for the Ethical AI Rating?" | grep -q "If all of these points are met, we give a Green label." || exit 1
.github/workflows/integration-test.yml:274
- The shell conditional in the summary step does not follow standard bash syntax; consider updating it to use proper test expressions (e.g., using [ ... ] or [[ ... ]]) for reliable evaluation.
run: if ${{ needs.changes.outputs.src != 'false' && needs.integration.result != 'success' }}; then exit 1; fi
Signed-off-by: Anupam Kumar <kyteinsky@gmail.com>
Signed-off-by: Anupam Kumar <kyteinsky@gmail.com>
kyteinsky
force-pushed
the
improve-int-test
branch
from
2df2cb3 to
01613b3
Compare
Signed-off-by: Anupam Kumar <kyteinsky@gmail.com>
marcelklehr
reviewed
Apr 1, 2025
marcelklehr
approved these changes
Apr 1, 2025
Signed-off-by: Anupam Kumar <kyteinsky@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.