fix: better error handling and performance improvements#198
Merged
Conversation
Contributor
kyteinsky
commented
Jul 29, 2025
kyteinsky
commented
- better retry mechanism in the embedding server
- no initial check for the embedding loader (perf.)
- fail fast for fatal embedding server errors
Signed-off-by: Anupam Kumar <kyteinsky@gmail.com>
Signed-off-by: Anupam Kumar <kyteinsky@gmail.com>
All the files in the request would not be removed from the queue in context_chat and retried later, hopefully when the embedding server is in a working state. Signed-off-by: Anupam Kumar <kyteinsky@gmail.com>
marcelklehr
approved these changes
Jul 29, 2025
Signed-off-by: Anupam Kumar <kyteinsky@gmail.com>
Merged
kyteinsky
added a commit
that referenced
this pull request
Jul 31, 2025
## 4.4.1 - 2025-07-31 ### Fixed - fail fast for fatal embedding server errors (#198) @kyteinsky - no initial check for the embedding loader (#198) @kyteinsky - better retry mechanism in the embedding server (#198) @kyteinsky Signed-off-by: Anupam Kumar <kyteinsky@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.