chore: Fix small psalm reported issues

come-nc · come-nc · commit 14774339b0bf · 2024-12-02T11:34:14.000+01:00
Signed-off-by: Côme Chilliet &lt;come.chilliet@nextcloud.com&gt;
diff --git a/lib/Services/Request.php b/lib/Services/Request.php
@@ -89,7 +89,7 @@ protected function craftEmailTo(IUser $admin, IEMailTemplate $template): bool {
 		$senderName = $this->defaults->getName();
 
 		$adminEmail = $admin->getEMailAddress();
-		if (!$adminEmail) {
+		if ($adminEmail === null || $adminEmail === '') {
 			return false;
 		}
 
@@ -141,7 +141,7 @@ protected function getDeletionTemplate(IUser $admin): IEMailTemplate {
 	}
 
 	protected function getAdmins(): array {
-		$admins = $this->groupManager->get('admin')->searchUsers('');
+		$admins = $this->groupManager->get('admin')?->searchUsers('') ?? [];
 		$admins = array_filter($admins, function (IUser $admin) {
 			return $admin->getEMailAddress() !== null;
 		});

Original file line number	Diff line number	Diff line change
`@@ -89,7 +89,7 @@ protected function craftEmailTo(IUser $admin, IEMailTemplate $template): bool {`
`89`	`89`	`$senderName = $this->defaults->getName();`
`90`	`90`
`91`	`91`	`$adminEmail = $admin->getEMailAddress();`
`92`		`- if (!$adminEmail) {`
	`92`	`+ if ($adminEmail === null \|\| $adminEmail === '') {`
`93`	`93`	`return false;`
`94`	`94`	`}`
`95`	`95`
`@@ -141,7 +141,7 @@ protected function getDeletionTemplate(IUser $admin): IEMailTemplate {`
`141`	`141`	`}`
`142`	`142`
`143`	`143`	`protected function getAdmins(): array {`
`144`		`- $admins = $this->groupManager->get('admin')->searchUsers('');`
	`144`	`+ $admins = $this->groupManager->get('admin')?->searchUsers('') ?? [];`
`145`	`145`	`$admins = array_filter($admins, function (IUser $admin) {`
`146`	`146`	`return $admin->getEMailAddress() !== null;`
`147`	`147`	`});`