Merge pull request #454 from nextcloud/backport/451/stable31

[stable31] feat: add user rate limiting for requests

Author: benjaminfrueh

js/app.js

@@ -47,13 +47,19 @@
 					$context.removeClass('loading');
 				},
 				error: function (response) {
-					$context.prop('disabled', '');
-					$context.removeClass('loading');
-					if(response.responseJSON && response.responseJSON.ocs.data.error) {
-						$context.siblings('span.warning')
-							.removeClass('hidden')
-							.html(response.responseJSON.ocs.data.error);
+					if (response.status !== 429) {
+						$context.prop('disabled', '');
 					}
+
+					$context.removeClass('loading');
+
+					const errorMessage = response.status === 429
+						? t('data_request', 'Already requested, please try again later.')
+						: (response.responseJSON?.ocs?.data?.error || t('data_request', 'Request failed'));
+
+					$context.siblings('span.warning')
+						.removeClass('hidden')
+						.html(errorMessage);
 				}
 			});
 		}

lib/Controller/DataRequestController.php

@@ -10,6 +10,7 @@
 use OCA\DataRequest\Exceptions\HintedRuntime;
 use OCA\DataRequest\Services\Request;
 use OCP\AppFramework\Http;
+use OCP\AppFramework\Http\Attribute\UserRateLimit;
 use OCP\AppFramework\Http\DataResponse;
 use OCP\AppFramework\OCSController;
 use OCP\IRequest;
@@ -33,6 +34,7 @@ public function __construct(
 	 * @NoAdminRequired
 	 * @PasswordConfirmationRequired
 	 */
+	#[UserRateLimit(limit: 1, period: 3600)]
 	public function export(): DataResponse {
 		return $this->processRequest(function (): void {
 			$this->dataRequest->sendExportRequest();
@@ -43,6 +45,7 @@ public function export(): DataResponse {
 	 * @NoAdminRequired
 	 * @PasswordConfirmationRequired
 	 */
+	#[UserRateLimit(limit: 1, period: 3600)]
 	public function deletion(): DataResponse {
 		return $this->processRequest(function (): void {
 			$this->dataRequest->sendDeleteRequest();