Fix: Allow boards with name '0'

Signed-off-by: Theo Hollweg <thollweg@mailbox.org>

Author: theoholl

lib/Validators/BaseValidator.php

@@ -104,6 +104,11 @@ private function not_null($value): bool {
 	 * @return bool
 	 */
 	private function not_empty($value): bool {
+		// Treat string zero as a valid non-empty value while still rejecting other empty values
+		if ($value === '0') {
+			return true;
+		}
+
 		return !empty($value);
 	}
 

tests/unit/Validators/BoardServiceValidatorTest.php

@@ -0,0 +1,47 @@
+<?php
+
+declare(strict_types=1);
+
+/**
+ *
+ * @license GNU AGPL version 3 or any later version
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as
+ * published by the Free Software Foundation, either version 3 of the
+ * License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+
+namespace OCA\Deck\Validators;
+
+use OCA\Deck\Tests\unit\Validators\ValidatorTestBase;
+
+class BoardServiceValidatorTest extends ValidatorTestBase {
+	public function setUp(): void {
+		parent::setUpValidatorTest(BoardServiceValidator::class);
+	}
+
+	public function testTitleZeroIsAccepted(): void {
+		$this->assertPass([
+			'title' => '0',
+		]);
+	}
+
+	public function testTitleEmptyIsRejected(): void {
+		$this->assertFail([
+			'title' => '',
+		]);
+		$this->assertFail([
+			'title' => null,
+		]);
+	}
+}