perf: Use getBoard to get the board

So that this can benefit from a local cache

Signed-off-by: Carl Schwan <carl.schwan@nextclound.com>

Author: Carl Schwan

lib/Service/PermissionService.php

@@ -214,7 +214,7 @@ public function findUsers($boardId, $refresh = false) {
 		}
 
 		try {
-			$board = $this->boardMapper->find($boardId);
+			$board = $this->getBoard($boardId);
 		} catch (DoesNotExistException $e) {
 			return [];
 		} catch (MultipleObjectsReturnedException $e) {
@@ -227,7 +227,7 @@ public function findUsers($boardId, $refresh = false) {
 		} else {
 			$users[$board->getOwner()] = new User($board->getOwner(), $this->userManager);
 		}
-		$acls = $this->aclMapper->findAll($boardId);
+		$acls = $board->getAcl();
 		/** @var Acl $acl */
 		foreach ($acls as $acl) {
 			if ($acl->getType() === Acl::PERMISSION_TYPE_USER) {

tests/unit/Service/PermissionServiceTest.php

@@ -347,9 +347,8 @@ public function testFindUsers() {
 			->method('__call')
 			->with('getOwner', [])
 			->willReturn('user1');
-		$this->aclMapper->expects($this->once())
-			->method('findAll')
-			->with(123)
+		$board->expects($this->any())
+			->method('getAcl')
 			->willReturn([$aclUser, $aclGroup]);
 		$this->boardMapper->expects($this->once())
 			->method('find')