fix(sharereview): harden and optimize implementation and testing

Assisted-by: Claude Code:claude-sonnet-4-6
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

Author: AndyScherzinger

lib/ShareReview/ShareReviewSource.php

@@ -76,11 +76,11 @@ private function fetchAllShares(): array {
 		try {
 			$qb = $this->db->getQueryBuilder();
 			$qb->select(
-				'a.id', 'a.type', 'a.participant',
+				'a.id', 'a.board_id', 'a.type', 'a.participant',
 				'a.permission_edit', 'a.permission_share', 'a.permission_manage'
 			)
-				->addSelect($qb->createFunction('b.title AS board_title'))
-				->addSelect($qb->createFunction('b.owner AS board_owner'))
+				->selectAlias('b.title', 'board_title')
+				->selectAlias('b.owner', 'board_owner')
 				->from(self::ACL_TABLE, 'a')
 				->leftJoin('a', self::BOARDS_TABLE, 'b', $qb->expr()->eq('a.board_id', 'b.id'))
 				->orderBy('a.id', 'ASC');
@@ -97,7 +97,7 @@ private function fetchAllShares(): array {
 	/** @param array<string, mixed> $share */
 	private function resolveObjectName(array $share): string {
 		$title = (string)($share['board_title'] ?? '');
-		$boardId = (int)$share['id'];
+		$boardId = (int)($share['board_id'] ?? $share['id']);
 		return ($title !== '' ? $title : "Board $boardId") . ' (Board)';
 	}
 

tests/unit/ShareReview/ShareReviewSourceTest.php

@@ -47,13 +47,13 @@ private function makeQb(array $fetchRows = [], int $statementRows = 0): MockObje
 		$qb = $this->createMock(IQueryBuilder::class);
 		$qb->method('select')->willReturnSelf();
 		$qb->method('addSelect')->willReturnSelf();
+		$qb->method('selectAlias')->willReturnSelf();
 		$qb->method('from')->willReturnSelf();
 		$qb->method('leftJoin')->willReturnSelf();
 		$qb->method('where')->willReturnSelf();
 		$qb->method('orderBy')->willReturnSelf();
 		$qb->method('delete')->willReturnSelf();
 		$qb->method('createNamedParameter')->willReturn('?');
-		$qb->method('createFunction')->willReturnArgument(0);
 		$qb->method('expr')->willReturn($expr);
 		$qb->method('executeQuery')->willReturn($this->makeResult($fetchRows));
 		$qb->method('executeStatement')->willReturn($statementRows);
@@ -67,13 +67,13 @@ private function makeThrowingQb(): MockObject {
 		$qb = $this->createMock(IQueryBuilder::class);
 		$qb->method('select')->willReturnSelf();
 		$qb->method('addSelect')->willReturnSelf();
+		$qb->method('selectAlias')->willReturnSelf();
 		$qb->method('from')->willReturnSelf();
 		$qb->method('leftJoin')->willReturnSelf();
 		$qb->method('where')->willReturnSelf();
 		$qb->method('orderBy')->willReturnSelf();
 		$qb->method('delete')->willReturnSelf();
 		$qb->method('createNamedParameter')->willReturn('?');
-		$qb->method('createFunction')->willReturnArgument(0);
 		$qb->method('expr')->willReturn($expr);
 		$qb->method('executeQuery')->willThrowException($this->createMock(Exception::class));
 		$qb->method('executeStatement')->willThrowException($this->createMock(Exception::class));
@@ -84,6 +84,7 @@ private function makeThrowingQb(): MockObject {
 	private function makeShareRow(array $overrides = []): array {
 		return array_merge([
 			'id' => 1,
+			'board_id' => 10,
 			'type' => 0,
 			'participant' => 'bob',
 			'board_title' => 'My Board',
@@ -157,7 +158,7 @@ public function testGetSharesRemoteShare(): void {
 
 	public function testGetSharesMissingBoardFallback(): void {
 		$this->db->method('getQueryBuilder')->willReturn(
-			$this->makeQb([$this->makeShareRow(['id' => 42, 'board_title' => null, 'board_owner' => null])])
+			$this->makeQb([$this->makeShareRow(['board_id' => 42, 'board_title' => null, 'board_owner' => null])])
 		);
 
 		$shares = $this->source->getShares();