Skip to content

Commit b442ed4

Browse files
fix: Use the new share meta-data instead of a hard-coded date
Assisted-by: Claude Code:claude-sonnet-4-6 Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
1 parent a226ab1 commit b442ed4

2 files changed

Lines changed: 15 additions & 3 deletions

File tree

lib/ShareReview/ShareReviewSource.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ public function getShares(): array {
5151
'recipient' => (string)$share['participant'],
5252
'permissions' => $this->computePermissions($share),
5353
'password' => false,
54-
'time' => '1970-01-01 01:00:00',
54+
'time' => date('Y-m-d H:i:s', max((int)$share['created_at'], (int)$share['last_modified_at'])),
5555
'action' => '',
5656
];
5757
}
@@ -77,7 +77,7 @@ private function fetchAllShares(): array {
7777
$qb = $this->db->getQueryBuilder();
7878
$qb->select(
7979
'a.id', 'a.board_id', 'a.type', 'a.participant',
80-
'a.permission_edit', 'a.permission_share', 'a.permission_manage'
80+
'a.permission_edit', 'a.permission_share', 'a.permission_manage', 'a.created_at', 'a.last_modified_at'
8181
)
8282
->selectAlias('b.title', 'board_title')
8383
->selectAlias('b.owner', 'board_owner')

tests/unit/ShareReview/ShareReviewSourceTest.php

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,8 @@ private function makeShareRow(array $overrides = []): array {
9292
'permission_edit' => 0,
9393
'permission_share' => 0,
9494
'permission_manage' => 0,
95+
'created_at' => 1700000000,
96+
'last_modified_at' => 0,
9597
], $overrides);
9698
}
9799

@@ -120,10 +122,20 @@ public function testGetSharesUserShare(): void {
120122
$this->assertSame('bob', $share['recipient']);
121123
$this->assertSame(Constants::PERMISSION_READ, $share['permissions']);
122124
$this->assertFalse($share['password']);
123-
$this->assertSame('1970-01-01 01:00:00', $share['time']);
125+
$this->assertSame(date('Y-m-d H:i:s', 1700000000), $share['time']);
124126
$this->assertSame('', $share['action']);
125127
}
126128

129+
public function testGetSharesUsesLastModifiedAtWhenNewer(): void {
130+
$this->db->method('getQueryBuilder')->willReturn(
131+
$this->makeQb([$this->makeShareRow(['created_at' => 1700000000, 'last_modified_at' => 1800000000])])
132+
);
133+
134+
$shares = $this->source->getShares();
135+
136+
$this->assertSame(date('Y-m-d H:i:s', 1800000000), $shares[0]['time']);
137+
}
138+
127139
public function testGetSharesGroupShare(): void {
128140
$this->db->method('getQueryBuilder')->willReturn(
129141
$this->makeQb([$this->makeShareRow(['type' => 1, 'participant' => 'developers'])])

0 commit comments

Comments
 (0)