Merge pull request #7660 from nextcloud/fixBoardIdNull

fix(session): Add null check for boardId in createSession

Author: grnd-alt

src/components/board/Board.vue

@@ -163,14 +163,14 @@ export default {
 		},
 	},
 	created() {
-		this.session = createSession(this.id)
+		// Session is created in fetchData() after loadBoardById succeeds
 		this.fetchData()
 		this.$root.$on('open-card', (cardId) => {
 			this.localModal = cardId
 		})
 	},
 	beforeDestroy() {
-		this.session.close()
+		this.session?.close()
 	},
 	methods: {
 		async fetchData() {

src/sessions.js

@@ -73,7 +73,7 @@ export function isNotifyPushEnabled() {
  */
 export function createSession(boardId) {
 
-	if (!isNotifyPushEnabled()) {
+	if (!boardId || !isNotifyPushEnabled()) {
 		// return a dummy object
 		return {
 			async close() {},
@@ -107,7 +107,7 @@ export function createSession(boardId) {
 			syncRunning = true
 			await sessionApi.syncSession(boardId, await tokenPromise)
 		} catch (err) {
-			if (err.response.status === 404) {
+			if (err.response?.status === 404) {
 				// session probably expired, let's
 				// create a fresh session
 				create()