[main] Add $changes->getBefore() to event in reorder#7124
Conversation
stpronk
requested review from
elzody,
grnd-alt and
luka-nextcloud
as code owners
stpronk
changed the title
$changes->getBefore() to event in reorder$changes->getBefore() to event in reorder
| if ($resetDuedateNotification) { | ||
| $this->notificationHelper->markDuedateAsRead($card); | ||
| } | ||
| $this->changeHelper->cardChanged($card->getId(), true); |
There was a problem hiding this comment.
"true" is default here, redundant argument
grnd-alt
left a comment
grnd-alt
left a comment
There was a problem hiding this comment.
Code changes look good, great thanks🔥
You can pick out more places where the before attribute would be useful if you want, but I think we'd be ready to merge this right now as well.
Do you mind rebasing and squashing the 3 commits into 1 before merging?
|
@grnd-alt Awesome to hear! 🔥 I will take a look at the other services what can be done & will squash the commits afterwards. thanks for the feedback! |
…ate where possible Signed-off-by: StPronk <stpronk@gmail.com>
|
@grnd-alt Squashed the commits and rebased the branch! Looked into the other services as well, yet I see more work there then initial thought. To keep the PR's clean, I will continue with it in separate branches! |
grnd-alt
left a comment
grnd-alt
left a comment
There was a problem hiding this comment.
Great Thanks, and congratulations on your first contribution 🔥
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
2 participants
Summary
Added
$changes->getBefore()to dispatched event to be able to see the before status when reordering. Now able to hook into the event and the the changes that have been made to be able to react properly to the given changes.TODO
Checklist