Migrate comment.js Vuex store to Pinia#7827
Conversation
theoholl
requested review from
elzody,
grnd-alt and
luka-nextcloud
as code owners
grnd-alt
left a comment
grnd-alt
left a comment
There was a problem hiding this comment.
did you test this? this breaks reactivity when deleting comments and when loading more comments than on initial fetch
|
Oh shoot, I'll review that. I thought I had tested deleting (adding, referencing, etc.) comments at least but I'll put this PR on hold until I tested more thoroughly. |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
| await apiClient.createComment({ cardId, comment, replyTo: this.replyTo }) | ||
| await this.fetchComments({ cardId }) | ||
| }, | ||
| async apiDeleteComment(data) { |
There was a problem hiding this comment.
I don't see a need for these api wrappers, better just merge that into one action
There was a problem hiding this comment.
Yes, currently there is no need to just add/remove/update comments from the state store without updating via API, so I merged those.
| 'hasMoreComments', | ||
| ]), | ||
| replyTo() { | ||
| return this.commentStore.replyTo |
There was a problem hiding this comment.
we can just use commentStore.replyTo, no need to have these extra computeds
There was a problem hiding this comment.
Makes sense to me.
Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>
Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>
Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>
Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>
Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>
grnd-alt
force-pushed
the
migrate-comment-store-to-pinia
branch
from
9f39122 to
9db9ea8
Compare
2 participants
Summary
This PR migrated the
comment.jsVuex store to Pinia, following patterns from #7790.