fix: avoid breaking card details modal when viewing attachment#7978
Merged
Conversation
Signed-off-by: Luka Trovic <luka@nextcloud.com>
grnd-alt
approved these changes
May 26, 2026
grnd-alt
left a comment
grnd-alt
left a comment
Member
There was a problem hiding this comment.
works, but feels a little hacky because the modal is rendered as a sidebar which seems to not have been expected by this pr in viewer: nextcloud/viewer#3058
would be cleaner to eventually refactor the modal to not use the sidebar component, but lets merge this for now!
|
Could i suggest a backport to 1.17 🙏 |
Contributor
Author
|
/backport to stable33 |
Contributor
Author
|
/backport to stable34 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hide the sidebar when viewing attachment if opening card in modal to avoid wrong sidebar position calculating in Viewer app
Checklist