Skip to content

refactor(pinia): move attachmentStore to pinia#8142

Merged
grnd-alt merged 1 commit into
mainfrom
refactor/pinia-migration-attachment-attachmentStore
Jul 15, 2026
Merged

refactor(pinia): move attachmentStore to pinia#8142
grnd-alt merged 1 commit into
mainfrom
refactor/pinia-migration-attachment-attachmentStore

Conversation

@grnd-alt

@grnd-alt grnd-alt commented Jul 7, 2026

Copy link
Copy Markdown
Member

No description provided.

@grnd-alt
grnd-alt requested a review from luka-nextcloud as a code owner July 7, 2026 11:58
@grnd-alt
grnd-alt force-pushed the refactor/pinia-migration-attachment-attachmentStore branch 2 times, most recently from 0c18fc1 to 944683c Compare July 8, 2026 09:40
@github-project-automation github-project-automation Bot moved this to 🧭 Planning evaluation (don't pick) in 📝 Productivity team Jul 9, 2026
@grnd-alt grnd-alt moved this from 🧭 Planning evaluation (don't pick) to 👀 In review in 📝 Productivity team Jul 9, 2026
@grnd-alt grnd-alt self-assigned this Jul 9, 2026
@grnd-alt
grnd-alt requested a review from samin-z July 9, 2026 09:10
Comment thread src/stores/attachment.js Outdated
Comment thread src/stores/attachment.js Outdated
@samin-z

samin-z commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Functionality check finds:

  1. file upload:
    upload a file and go back to the overview there is no attachment icon and counter on the card, i have to refresh the page to see the attachment increase.

  2. attachment delete is not working to check but that issue also exist on main so not caused by this pr.

Signed-off-by: grnd-alt <git@belakkaf.net>
@grnd-alt
grnd-alt force-pushed the refactor/pinia-migration-attachment-attachmentStore branch from 944683c to 6202190 Compare July 13, 2026 12:22
@grnd-alt
grnd-alt requested a review from samin-z July 13, 2026 12:31
@samin-z

samin-z commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Functionality check finds:

  1. file upload:
    upload a file and go back to the overview there is no attachment icon and counter on the card, i have to refresh the page to see the attachment increase.
  2. attachment delete is not working to check but that issue also exist on main so not caused by this pr.

both are resolved ✅

not sure how second one is resolved, but ill do more testing in this regard and see if i can reproduce it again.

@grnd-alt
grnd-alt merged commit 307b9ee into main Jul 15, 2026
41 checks passed
@grnd-alt
grnd-alt deleted the refactor/pinia-migration-attachment-attachmentStore branch July 15, 2026 07:44
@github-project-automation github-project-automation Bot moved this from 👀 In review to ☑️ Done in 📝 Productivity team Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ☑️ Done

Development

Successfully merging this pull request may close these issues.

2 participants