Merge pull request #9819 from nextcloud/codex/evaluate-and-possibly-remove-obsolete-code-section

Remove Windows Shell/Explorer pinning fallback commands from SocketApi

Author: mgallien

src/gui/socketapi/socketapi.cpp

@@ -910,24 +910,6 @@ class GetOrCreatePublicLinkShare : public QObject
 
 #endif
 
-// Windows Shell / Explorer pinning fallbacks, see issue: https://github.com/nextcloud/desktop/issues/1599
-#ifdef Q_OS_WIN
-void SocketApi::command_COPYASPATH(const QString &localFile, SocketListener *)
-{
-    setClipboardText(localFile);
-}
-
-void SocketApi::command_OPENNEWWINDOW(const QString &localFile, SocketListener *)
-{
-    QDesktopServices::openUrl(QUrl::fromLocalFile(localFile));
-}
-
-void SocketApi::command_OPEN(const QString &localFile, SocketListener *socketListener)
-{
-    command_OPENNEWWINDOW(localFile, socketListener);
-}
-#endif
-
 // Fetches the private link url asynchronously and then calls the target slot
 void SocketApi::fetchPrivateLinkUrlHelper(const QString &localFile, const std::function<void(const QString &url)> &targetFun)
 {

src/gui/socketapi/socketapi.h

@@ -143,13 +143,6 @@ private slots:
 
     void setFileLock(const QString &localFile, const SyncFileItem::LockStatus lockState) const;
 
-    // Windows Shell / Explorer pinning fallbacks, see issue: https://github.com/nextcloud/desktop/issues/1599
-#ifdef Q_OS_WIN
-    Q_INVOKABLE void command_COPYASPATH(const QString &localFile, OCC::SocketListener *listener);
-    Q_INVOKABLE void command_OPENNEWWINDOW(const QString &localFile, OCC::SocketListener *listener);
-    Q_INVOKABLE void command_OPEN(const QString &localFile, OCC::SocketListener *listener);
-#endif
-
     // Fetch the private link and call targetFun
     void fetchPrivateLinkUrlHelper(const QString &localFile, const std::function<void(const QString &url)> &targetFun);