fix(lockedFiles): ensure locked files seen during discovery are known

will ensure we watch them and sync them as soon as they are no longer
locked

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Author: mgallien

src/libsync/discovery.cpp

@@ -262,6 +262,8 @@ bool ProcessDirectoryJob::handleExcluded(const QString &path, const Entries &ent
     if (OCC::FileSystem::isFileLocked(_discoveryData->_localDir + path, OCC::FileSystem::LockMode::SharedRead)) {
         qCInfo(lcDisco) << _discoveryData->_localDir + path << "is locked" << "exluding it from sync";
         excluded = CSYNC_FILE_SILENTLY_EXCLUDED;
+
+        emit _discoveryData->seenLockedFile(path);
     }
 
     const auto fileName = path.mid(path.lastIndexOf('/') + 1);

src/libsync/discoveryphase.h

@@ -345,6 +345,9 @@ class DiscoveryPhase : public QObject
     void addErrorToGui(const OCC::SyncFileItem::Status status, const QString &errorMessage, const QString &subject, const OCC::ErrorCategory category);
 
     void remnantReadOnlyFolderDiscovered(const OCC::SyncFileItemPtr &item);
+
+    /** Emitted when propagation would have problems with a locked file. */
+    void seenLockedFile(const QString &fileName);
 private slots:
     void slotItemDiscovered(const OCC::SyncFileItemPtr &item);
 };

src/libsync/syncengine.cpp

@@ -708,6 +708,7 @@ void SyncEngine::startSync()
     connect(_discoveryPhase.get(), &DiscoveryPhase::silentlyExcluded,
         _syncFileStatusTracker.data(), &SyncFileStatusTracker::slotAddSilentlyExcluded);
     connect(_discoveryPhase.get(), &DiscoveryPhase::remnantReadOnlyFolderDiscovered, this, &SyncEngine::remnantReadOnlyFolderDiscovered);
+    connect(_discoveryPhase.get(), &DiscoveryPhase::seenLockedFile, this, &SyncEngine::seenLockedFile);
 
     ProcessDirectoryJob *discoveryJob = nullptr;