refactor(discovery): ranges, ref captures, precision, const localJob

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

Author: solracsf

src/libsync/discovery.cpp

@@ -2113,7 +2113,7 @@ QStringList ProcessDirectoryJob::queryEditorsKeepingFileBusy(const SyncFileItemP
     }
 
     if (const auto isMatchingFileExtension = std::ranges::find_if(kFileExtsForSigning,
-            [path](const auto &matchingExtension) {
+            [&path](const auto &matchingExtension) {
                 return path._local.endsWith(matchingExtension, Qt::CaseInsensitive);
             }) != std::cend(kFileExtsForSigning);
         !isMatchingFileExtension) {
@@ -2124,8 +2124,8 @@ QStringList ProcessDirectoryJob::queryEditorsKeepingFileBusy(const SyncFileItemP
     const auto editorsKeepingFileBusy = Utility::queryProcessInfosKeepingFileOpen(fullLocalPath);
 
     for (const auto &detectedEditorName : editorsKeepingFileBusy) {
-        const auto isMatchingEditorFound = std::find_if(std::cbegin(editorNamesForDelayedUpload), std::cend(editorNamesForDelayedUpload),
-            [detectedEditorName](const auto &matchingEditorName) {
+        const auto isMatchingEditorFound = std::ranges::find_if(editorNamesForDelayedUpload,
+            [&detectedEditorName](const auto &matchingEditorName) {
                 return detectedEditorName.processName.startsWith(matchingEditorName, Qt::CaseInsensitive);
             }) != std::cend(editorNamesForDelayedUpload);
         if (isMatchingEditorFound) {
@@ -2185,7 +2185,7 @@ void ProcessDirectoryJob::subJobFinished()
     if (job->_dirItem)
         emit _discoveryData->itemDiscovered(job->_dirItem);
 
-    int count = _runningJobs.removeAll(job);
+    const auto count = _runningJobs.removeAll(job);
     ASSERT(count == 1);
     job->deleteLater();
     QTimer::singleShot(0, _discoveryData, &DiscoveryPhase::scheduleMoreJobs);
@@ -2366,7 +2366,7 @@ void ProcessDirectoryJob::setFolderQuota(const FolderQuota &folderQuota)
 void ProcessDirectoryJob::startAsyncLocalQuery()
 {
     QString localPath = _discoveryData->_localDir + _currentFolder._local;
-    auto localJob = new DiscoverySingleLocalDirectoryJob(_discoveryData->_account, localPath, _discoveryData->_syncOptions._vfs.data(), _discoveryData->_fileSystemReliablePermissions);
+    auto *const localJob = new DiscoverySingleLocalDirectoryJob(_discoveryData->_account, localPath, _discoveryData->_syncOptions._vfs.data(), _discoveryData->_fileSystemReliablePermissions);
 
     _discoveryData->_currentlyActiveJobs++;
     _pendingAsyncJobs++;