Skip to content

Commit d5048b2

Browse files
committed
fix(socketapi): remove doWait from broadcastMessage in slotUnregisterPath.
Passing doWait=true caused socket->waitForBytesWritten(1000) to emit a signal. During shutdown, the signal could trigger slotUnregisterPath, corrupting _registeredAliases and crashing with EXC_BAD_ACCESS. Removing doWait eliminates the nested event loop and the re-entrancy. Signed-off-by: Camila Ayres <hello@camilasan.com>
1 parent 50e6ba6 commit d5048b2

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

src/gui/socketapi/socketapi.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -475,7 +475,7 @@ void SocketApi::slotUnregisterPath(const QString &alias)
475475

476476
Folder *f = FolderMan::instance()->folder(alias);
477477
if (f)
478-
broadcastMessage(buildMessage(QLatin1String("UNREGISTER_PATH"), removeTrailingSlash(f->path()), QString()), true);
478+
broadcastMessage(buildMessage(QLatin1String("UNREGISTER_PATH"), removeTrailingSlash(f->path()), QString()));
479479

480480
_registeredAliases.remove(alias);
481481
}

0 commit comments

Comments
 (0)