Skip to content

Commit fa2b631

Browse files
committed
refactor(windows): remove obsolete Explorer fallback socket commands
These fallback handlers were kept for legacy shell verb compatibility. With current-client-only integrations, they are no longer needed. Signed-off-by: Rello <Rello@users.noreply.github.com>
1 parent 8cda11a commit fa2b631

2 files changed

Lines changed: 0 additions & 25 deletions

File tree

src/gui/socketapi/socketapi.cpp

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -910,24 +910,6 @@ class GetOrCreatePublicLinkShare : public QObject
910910

911911
#endif
912912

913-
// Windows Shell / Explorer pinning fallbacks, see issue: https://github.com/nextcloud/desktop/issues/1599
914-
#ifdef Q_OS_WIN
915-
void SocketApi::command_COPYASPATH(const QString &localFile, SocketListener *)
916-
{
917-
setClipboardText(localFile);
918-
}
919-
920-
void SocketApi::command_OPENNEWWINDOW(const QString &localFile, SocketListener *)
921-
{
922-
QDesktopServices::openUrl(QUrl::fromLocalFile(localFile));
923-
}
924-
925-
void SocketApi::command_OPEN(const QString &localFile, SocketListener *socketListener)
926-
{
927-
command_OPENNEWWINDOW(localFile, socketListener);
928-
}
929-
#endif
930-
931913
// Fetches the private link url asynchronously and then calls the target slot
932914
void SocketApi::fetchPrivateLinkUrlHelper(const QString &localFile, const std::function<void(const QString &url)> &targetFun)
933915
{

src/gui/socketapi/socketapi.h

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -143,13 +143,6 @@ private slots:
143143

144144
void setFileLock(const QString &localFile, const SyncFileItem::LockStatus lockState) const;
145145

146-
// Windows Shell / Explorer pinning fallbacks, see issue: https://github.com/nextcloud/desktop/issues/1599
147-
#ifdef Q_OS_WIN
148-
Q_INVOKABLE void command_COPYASPATH(const QString &localFile, OCC::SocketListener *listener);
149-
Q_INVOKABLE void command_OPENNEWWINDOW(const QString &localFile, OCC::SocketListener *listener);
150-
Q_INVOKABLE void command_OPEN(const QString &localFile, OCC::SocketListener *listener);
151-
#endif
152-
153146
// Fetch the private link and call targetFun
154147
void fetchPrivateLinkUrlHelper(const QString &localFile, const std::function<void(const QString &url)> &targetFun);
155148

0 commit comments

Comments
 (0)