Fix Open Local Folder#10008
Merged
Merged
Conversation
i2h3
added
bug
os: 🍎 macOS
github-project-automation
Bot
moved this to 🧭 Planning evaluation (don't pick)
in 💻 Desktop Clients team
…lders As I found during development, due to sandbox restrictions it is not possible to provide a deep link popup menu for group folders, given there are some. Neither the main app nor the extension are allowed to delegate the revelation to Finder for different reasons due to the sandboxing. Signed-off-by: Iva Horn <iva.horn@nextcloud.com>
i2h3
force-pushed
the
i2h3/fix/9239-open-folder
branch
from
b110160 to
ae1abfe
Compare
i2h3
moved this from 🧭 Planning evaluation (don't pick)
to 🏗️ In progress
in 💻 Desktop Clients team
|
Artifact containing the AppImage: nextcloud-appimage-pr-10008.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
github-project-automation
Bot
moved this from 🏗️ In progress
to ☑️ Done
in 💻 Desktop Clients team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Offer local folder opening regardless of the presence of shared group folders which result in a dropdown menu item for classic synchronization folders.
As I found during development, due to sandbox restrictions it is not possible to provide a deep link popup menu for group folders, given there are some. Neither the main app nor the extension are allowed to delegate the revelation to Finder for different reasons due to the sandboxing.
This is a fix-up to #9857 and closes #9239.
No backport because it is part of a feature which will be delivered with release 34.0.0.